From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888AbbIKQMJ (ORCPT ); Fri, 11 Sep 2015 12:12:09 -0400 Received: from mga14.intel.com ([192.55.52.115]:9187 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbbIKQMG (ORCPT ); Fri, 11 Sep 2015 12:12:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,511,1437462000"; d="scan'208";a="787502411" From: Alexander Shishkin To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Johannes Berg , Linus Torvalds , Thomas Gleixner , adrian.hunter@intel.com, Ingo Molnar , Borislav Petkov , Vince Weaver , linux-kernel@vger.kernel.org, Andrew Morton , Peter Zijlstra , "H. Peter Anvin" , Stephane Eranian Subject: Re: [PATCH v2 0/6] perf: Introduce extended syscall error reporting In-Reply-To: <20150826205823.GB1139@kernel.org> References: <20150825091740.GA23488@gmail.com> <1440495246.2192.13.camel@sipsolutions.net> <20150825100728.GA1820@gmail.com> <1440497981.2192.39.camel@sipsolutions.net> <20150826044948.GC14584@gmail.com> <1440572775.1932.1.camel@sipsolutions.net> <20150826072020.GA19081@gmail.com> <20150826072656.GA19305@gmail.com> <87r3mqgf8w.fsf@ashishki-desk.ger.corp.intel.com> <20150826205823.GB1139@kernel.org> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 11 Sep 2015 19:11:29 +0300 Message-ID: <871te5ey1a.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnaldo Carvalho de Melo writes: > Em Wed, Aug 26, 2015 at 07:56:47PM +0300, Alexander Shishkin escreveu: >> So I hacked stuff a bit [1] to accomodate some of the above >> ideas. The below diff shows how these ideas integrate with perf. The >> rest is in my github tree. >> >> - this exterr implementation allows its users to add arbitrary >> information to the call site structures and also pretty print them on >> the way out; in the example, perf stores perf_event_attr field name >> that is the source of trouble; it's a string rather than offsetof(), >> because half of our event attribute is a bit field; >> - the "way out" doesn't have to be syscall return path (although in the >> example it is); >> - userspace can fetch the extended error reports via prctl() like you >> suggested above; >> - error codes are still passed around in the [-EXT_ERRNO..-MAX_ERRNO] >> range until they are passed to userspace (which is where ext_err_code() >> converts them back to traditional errno.h values). > > Hey, can we see the builtin-record.c patch please? Should be on the way to your inbox. Cheers, -- Alex