From: Rusty Russell <rusty@rustcorp.com.au>
To: Alexander Duyck <alexander.h.duyck@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Cc: mst@redhat.com
Subject: Re: [PATCH] virtio_ring: Update weak barriers to use dma_wmb/rmb
Date: Fri, 10 Apr 2015 12:47:01 +0930 [thread overview]
Message-ID: <871tjs1xle.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20150408004742.2112.25484.stgit@ahduyck-vm-fedora22>
Alexander Duyck <alexander.h.duyck@redhat.com> writes:
> This change makes it so that instead of using smp_wmb/rmb which varies
> depending on the kernel configuration we can can use dma_wmb/rmb which for
> most architectures should be equal to or slightly more strict than
> smp_wmb/rmb.
>
> The advantage to this is that these barriers are available to uniprocessor
> builds as well so the performance should improve under such a
> configuration.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
This seems OK to me, since it's really as much a cleanup as anything,
but like you I do wonder if there benefit on ARM in practice.
Applied, thanks.
Cheers,
Rusty.
prev parent reply other threads:[~2015-04-11 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 0:47 Alexander Duyck
2015-04-08 8:42 ` Michael S. Tsirkin
2015-04-08 14:41 ` Alexander Duyck
2015-04-08 18:37 ` Michael S. Tsirkin
2015-04-08 20:31 ` Alexander Duyck
2015-04-10 3:17 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tjs1xle.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alexander.h.duyck@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome