From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [for-next][PATCH v2 1/3] tracing: Fix syscall_*regfunc() vs copy_process() race
Date: Tue, 24 Jun 2014 15:55:41 +0900 [thread overview]
Message-ID: <871tue7q4y.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140620104711.140660296@goodmis.org> (Steven Rostedt's message of "Fri, 20 Jun 2014 06:45:19 -0400")
Hi Steve,
On Fri, 20 Jun 2014 06:45:19 -0400, Steven Rostedt wrote:
> From: Oleg Nesterov <oleg@redhat.com>
>
> syscall_regfunc() and syscall_unregfunc() should set/clear
> TIF_SYSCALL_TRACEPOINT system-wide, but do_each_thread() can race
> with copy_process() and miss the new child which was not added to
> the process/thread lists yet.
>
> Change copy_process() to update the child's TIF_SYSCALL_TRACEPOINT
> under tasklist.
s/tasklist/tasklist_lock/ ?
Probably I'm too late..
Thanks,
Namhyung
next prev parent reply other threads:[~2014-06-24 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 10:45 [for-next][PATCH v2 0/3] tracing: Fixes to syscall tracing Steven Rostedt
2014-06-20 10:45 ` [for-next][PATCH v2 1/3] tracing: Fix syscall_*regfunc() vs copy_process() race Steven Rostedt
2014-06-21 1:11 ` Paul E. McKenney
2014-06-21 1:19 ` Steven Rostedt
2014-06-24 6:55 ` Namhyung Kim [this message]
2014-06-26 17:49 ` Steven Rostedt
2014-06-20 10:45 ` [for-next][PATCH v2 2/3] tracing: Change syscall_*regfunc() to check PF_KTHREAD and use for_each_process_thread() Steven Rostedt
2014-06-20 10:45 ` [for-next][PATCH v2 3/3] tracing: syscall_regfunc() should not skip kernel threads Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tue7q4y.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome