mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 1/2] perf tests: Factor out fake_setup_machine()
Date: Mon, 28 Apr 2014 08:59:42 +0900	[thread overview]
Message-ID: <871twiqq6p.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140425122734.GD4116@krava.brq.redhat.com> (Jiri Olsa's message of "Fri, 25 Apr 2014 14:27:34 +0200")

Hi Jiri,

On Fri, 25 Apr 2014 14:27:34 +0200, Jiri Olsa wrote:
> On Fri, Apr 25, 2014 at 12:28:13PM +0900, Namhyung Kim wrote:
>> The fake_setup_machine() is for setting up a environment for testing
>> various hists operations.  As it'll be used for other test cases it'd
>> better factoring it out.
>
> looks like print_hists could be in hists_common.c as well..
> within another update ;-)

The difference is that one in hists_link.c is working on the input tree
while one in hists_filter.c is working on the output tree.

>
> nice!
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> for patchset

Thanks for review!
Namhyung

  reply	other threads:[~2014-04-27 23:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  3:28 Namhyung Kim
2014-04-25  3:28 ` [PATCH 2/2] perf tests: Add a test case for hists filtering Namhyung Kim
2014-04-29  6:45   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-25 12:27 ` [PATCH 1/2] perf tests: Factor out fake_setup_machine() Jiri Olsa
2014-04-27 23:59   ` Namhyung Kim [this message]
2014-04-28 11:20     ` Jiri Olsa
2014-04-29  6:45 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871twiqq6p.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome