mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Prevent condition that all sort keys are elided
Date: Tue, 12 Nov 2013 16:14:04 +0900	[thread overview]
Message-ID: <871u2mw0qr.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20131111112013.GC15810@gmail.com> (Ingo Molnar's message of "Mon, 11 Nov 2013 12:20:13 +0100")

Hi Ingo,

On Mon, 11 Nov 2013 12:20:13 +0100, Ingo Molnar wrote:
> * Namhyung Kim <namhyung@kernel.org> wrote:
>> +	/*
>> +	 * It makes no sense to elide all of sort entries.
>> +	 * Just revert them to show up again.
>> +	 */
>> +	list_for_each_entry(se, &hist_entry__sort_list, list)
>> +		if (!se->elide)
>> +			return;
>
> (Nit: please use curly braces around multi-line statements.)

Ah, okay.

>
>> +
>> +	list_for_each_entry(se, &hist_entry__sort_list, list)
>> +		se->elide = false;
>
> Looks good otherwise - this is the first step in the sort/key behavior 
> improvements that we talked about a few days ago, right?

Right.  And I'd like to wait bit more to hear other's opinion on this.

>
> Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,
Namhyung

  reply	other threads:[~2013-11-12  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08  8:53 Namhyung Kim
2013-11-11 11:20 ` Ingo Molnar
2013-11-12  7:14   ` Namhyung Kim [this message]
2013-11-12 21:55 ` [tip:perf/urgent] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u2mw0qr.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®