From: Namhyung Kim <namhyung@kernel.org>
To: Alex Shi <alex.shi@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Mike Galbraith <efault@gmx.de>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] sched: Get rid of unnecessary checks from select_idle_sibling
Date: Wed, 09 Jan 2013 17:00:23 +0900 [thread overview]
Message-ID: <871udurdk8.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <50ED1E63.8090008@intel.com> (Alex Shi's message of "Wed, 09 Jan 2013 15:38:11 +0800")
On Wed, 09 Jan 2013 15:38:11 +0800, Alex Shi wrote:
>>
>> Uh, we don't know if the target is this_cpu or previous cpu, If we just
>> check the target idle status, we may miss another idle cpu. So this
>> patch change the logical in this function.
>
> But, you can fold wake_affine into select_idle_sibling(). that will save
> a complicate calculation whichever cpu idle. :)
Looks like a good idea. :) Will send v2.
Thanks,
Namhyung
next prev parent reply other threads:[~2013-01-09 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 6:50 Namhyung Kim
2013-01-09 7:33 ` Alex Shi
2013-01-09 7:38 ` Alex Shi
2013-01-09 8:00 ` Namhyung Kim [this message]
2013-01-09 7:54 ` Namhyung Kim
2013-01-09 8:34 ` Alex Shi
2013-01-10 5:52 ` Namhyung Kim
2013-01-11 2:36 ` Alex Shi
2013-01-09 8:21 ` Preeti U Murthy
2013-01-10 5:49 ` Namhyung Kim
2013-01-10 8:19 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871udurdk8.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alex.shi@intel.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome