Re: [PATCH] [trivial] fs/vfat: add *.cmd to filenames listed as executable by mount option "showexec"

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Roland Eggner <edvx1@systemanalysen.net> writes:

> On 2012-02-03 Fr 16:41:16 +0900, OGAWA Hirofumi wrote:
>> Roland Eggner <edvx1@systemanalysen.net> writes:
>> 
>> > The mount option "showexec" provides a somewhat more native view of vfat
>> > filesystems: only filenames *.exe *.com *.bat are listed as
>> > executable, rather
>> > than all files.  This patch adds filenames *.cmd to those listed
>> > as executable.
>> > *.cmd are usually scripts associated with the shell "cmd.exe",
>> > which has been
>> > the default shell in several OS versions of its vendor.
>> >
>> > Signed-off-by: Roland Eggner <edvx1@systemanalysen.net>
>> > ---
>> 
>> Hm, this may be good for someone, but this may not be for someone. So,
>> this probably should be option if someone really care it.
>> 
>> I'm not thinking about how though...
>> 
> Think of VM images of recent versions of the FAT originating OS:  currently
> "showexec" will miss roughly half of the files, for which it is intended for.
> IMHO this patch provides a very cheap completion of a feature of the vfat kernel
> module.  Cheap in terms of only 9 characters additional source code.
>
> If you really see an advantage in the current, incomplete state of the
> "showexec" feature, compared to the proposed, completed state:  please elaborate
> your objection.

You would be happy with adding "cmd", and may think enough. But Someone
is not happy with it. And someone want to add "sh", "py", and "pl".

If I have to tackle it, why I have to make happy only your state? I'm
not saying current has advantage, I'm saying your patch doesn't make
guys happy like current one. It is just moving a place of happiness from
a group to an another group, right?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>