From: Eric Anholt <eric@anholt.net>
To: Jan Beulich <JBeulich@novell.com>
Cc: Brice.Goglin@ens-lyon.org, airlied@linux.ie,
linux-kernel@vger.kernel.org
Subject: Re: agp/intel: Fix the pre-9xx chipset flush
Date: Mon, 20 Sep 2010 16:57:45 -0700 [thread overview]
Message-ID: <871v8oufwm.fsf@pollan.anholt.net> (raw)
In-Reply-To: <4C922C700200007800016CB4@vpn.id2.novell.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On Thu, 16 Sep 2010 13:40:48 +0100, "Jan Beulich" <JBeulich@novell.com> wrote:
> Eric,
>
> in this patch you removed from intel_i830_setup_flush() a call to
> map_page_into_agp(), but you left in place the counterpart call from
> intel_i830_fini_flush() to unmap_page_from_agp()? Isn't it mere luck
> that on x86 this is only a call to set_pages_wb()?
Sounds like just an oversight.
> Further, is there really a point in doing the respective allocation
> with GFP_DMA32? Nor does __GFP_ZERO seem really necessary...
The hardware in question doesn't have memory above 32 bits, so either
way doesn't matter much. Yeah, GFP_ZERO doesn't seem needed.
If you've got patches for agp, Chris Wilson's the kernel module
maintainer now, and Daniel Vetter's got a huge changeset queued to -next
to clean up the disaster that is the "agp" code for integrated graphics.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2010-09-20 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 12:40 Jan Beulich
2010-09-20 23:57 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871v8oufwm.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=Brice.Goglin@ens-lyon.org \
--cc=JBeulich@novell.com \
--cc=airlied@linux.ie \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®