From: Dave Hansen <dave.hansen@intel.com>
To: Yury Norov <yury.norov@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH RFC] x86/apic: skip cpu slot reservation logic on boot in case of NR_CPUS == 1
Date: Fri, 2 Sep 2022 10:14:51 -0700 [thread overview]
Message-ID: <8722acbe-c668-5b05-c030-565f8c42068c@intel.com> (raw)
In-Reply-To: <20220902164211.1425982-1-yury.norov@gmail.com>
On 9/2/22 09:42, Yury Norov wrote:
> This is RFC because I'm not sure that this is not a false positive from
> smatch. If NR_CPUS is 1, and the condition is always true, it's simply
> optimized out by a compiler, and nothing wrong happens, except maybe a
> couple of checks on boot.
I think it's a reasonable warning, but it's also not something we need
to hack around. We can surely only land in here with
boot_cpu_detected==true if NR_CPUS==1, so the rest of the expression is
moot.
I don't think it's worth adding the #ifdef.
next prev parent reply other threads:[~2022-09-02 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 16:42 Yury Norov
2022-09-02 17:14 ` Dave Hansen [this message]
2022-09-02 17:35 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8722acbe-c668-5b05-c030-565f8c42068c@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®