From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EABC61F0E58 for ; Mon, 3 Mar 2025 23:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741043768; cv=none; b=Nkid+Gn/CiDojpnFQpFHtl3dK3vQzirmejIxo+M9KbkSG/tvt4IFLvpMfWTNcVzjWr8XAD0R4gynKbdLI/xVNmg4Y3wL28Q1qR8oVDusmS0kr0Yp85c63Z7VCMi8gqVS52gFy8CZ1IpwzFBjaFvGs3yJ0lladsW9dUrRsypIuTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741043768; c=relaxed/simple; bh=JtGPOleLjdfXbZkxAW7kB6ce08nn8jQ6Cj9OFLxNyjA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=azMw3iE8CO6NIaSNAYijBOSvqqwMpQppPzzgPYIaPIZjmuOLgZsTWvJZtUn+ZUkkO6RsRXmFQkuCVekxIBEIh5d4u+SgBWTpViVsXAo1RYtcnDpXRTsYgJKGHj9XRQFQN8SkJWLtNBr0GGZfgfeSJJj6nni+3ELyKCBcx8dfuLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Ld0AO+zA; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Ld0AO+zA" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2fea8d8c322so9158964a91.2 for ; Mon, 03 Mar 2025 15:16:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1741043766; x=1741648566; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=JFVk3jY5U6LDFO87gwMrK1J3W+7gmQZoy3PQR5ret7o=; b=Ld0AO+zAwPD2AuR8a5pW4CD2cJ0EVug8zfUhFGWnvQQAOrydqeFSvVr272nR9FBXKR C0mwv9IAQt48o4h65P66UNM6O6gO0Plhcv3d/i99y3K2N/prB7CX1iL+VFoinrojR5DK cVvxI05/IR9dGvtcNp/kOhZp1C272ogPBsDvk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741043766; x=1741648566; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JFVk3jY5U6LDFO87gwMrK1J3W+7gmQZoy3PQR5ret7o=; b=MNbTRDxxHcyAlA6vEaT8kUS/QXVSI55MCeNtnGaEgj6Xd88F5VxUQzaiXDH4GHcN1Y TT/kJg6Q/3MDTK7E3FWS0ihNqHP9UI/Tx8x8n53+rB2Qm9X1WAP6qezhbR5q6/FJZ2Xr L3GkDMYESUT+vdbrMDQLBhBhmSIYVOno/GBZz2AnxjIm5p45nO/noAb8JI1GXxdm8jnZ 0uk/Gr7ciuz9HwsB997IwBlAbuRyAjy/nMaXjHkQ8RuLux+kuTkPXtHiAgKxBtEdUnXm Zn8D+whScSr1l4nqfGFQB6q0B+Hb2yw3i9/9JR2qfO9YHodKHUKYd1JJKz1oY5FWuYld s89g== X-Forwarded-Encrypted: i=1; AJvYcCWr2/VeXdcCWoMGECjLEXl8NCBi/98ZGA7GvhbGojjHy5mhLoEQqDrkyl/vdNHPySLMcwiAn1A0n9Q22L4=@vger.kernel.org X-Gm-Message-State: AOJu0YzTNKasESMKH9Ex7ecib+iRK/a53Vc/7iTuf1wLidIjMPegLZfP hLWMmsgCqCB59UYRcykwHe1I9uCBlNZ8VAduQnuv6OVzoCc9AmmF/kAhDm+oNw== X-Gm-Gg: ASbGncuL67W43SUMU1hz4r4DsAzGsB9ueC2U0WM1rZfzSDIl9EWqj4YCksHE0W0aCWv h2sa27cEdW6g/MfsbX4nvKnTX4LwCyg5TeG/fw7SnMtRc7osCmo07wwBF5d8bEvv1qg+U56+y7n vq7FB2ZAdQryMx82OCT4a0bqBMXwfHKk18ozHmb1/EPMSUYCei8W5JGrxyebezwcQE0vwi8e7nv lSCb/5hlxVdbj1pJ3n1p7eh3G4/T1OsV+lulkHotGW0mAd/8NYvotgdXZQqAOsTy8efhDDeDfK+ GpwGRrwNzSiymfmDsj49yAwZlPDxUcR7nnucLZSyiYgmypr2XMRzw7sO/QPb0O0xr9j68oQLGig HwuGcehAh X-Google-Smtp-Source: AGHT+IE9RJqN+FSr3yir/3mq4w/zBZ12bOp9zXc3KTsmManVgz5U5aMY7SLoCn1sLP07bcqz+slxQQ== X-Received: by 2002:a17:90b:2792:b0:2fa:137f:5c61 with SMTP id 98e67ed59e1d1-2febab50e88mr28906831a91.12.1741043766104; Mon, 03 Mar 2025 15:16:06 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fea6990024sm9558523a91.45.2025.03.03.15.16.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 15:16:05 -0800 (PST) Message-ID: <87241686-90b5-44fe-b4e9-1a59451e3575@broadcom.com> Date: Mon, 3 Mar 2025 15:16:02 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: Warn (and therefore taint the kernel) on clk_ignore_unused To: Stephen Boyd , Konrad Dybcio , Michael Turquette Cc: Marijn Suijten , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio References: <20250201-topic-ignore_unused_warn-v1-1-f29db78cea3a@oss.qualcomm.com> <93b5004dacfe1151ca3abbb0fa31eaa6.sboyd@kernel.org> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <93b5004dacfe1151ca3abbb0fa31eaa6.sboyd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/3/25 14:48, Stephen Boyd wrote: > Quoting Konrad Dybcio (2025-02-01 08:52:30) >> From: Konrad Dybcio >> >> If any sort of ignore_unused is in place, it means one of: >> >> * power is going to waste >> * the platform description is incomplete (missing consumer-provider >> relationships) >> * the platform description is just broken >> >> Many people will happily declare their job done when a platform >> magically happens to work as they make use of bootloader-enabled >> resources, which then leads to double or triple the amount of work >> of another person, as they attempt to reduce the unnecessary power >> drainage and/or ensure stabiility throughout a suspend-resume cycle. >> >> Issue a good ol' warning (and taint the kernel) to make such cases >> obvious and hopefully draw more attention to it. This way, it'll be >> easier to avoid effectively untested code or DT description getting >> merged into the kernel, or worse, going into production. >> >> The clock subsystem plays a crucial part in this quest, as even if >> the clock controllers themselves don't draw a lot of power when on >> (comparatively), improper description of clock requirements has been >> the #1 cause of incomplete/incorrect devicetree bindings in my >> experience. > > What is a user supposed to do about this warning stack? We already print > a warning. I don't see us dumping the stack when a driver is unfinished > and doesn't implement runtime PM to save power. > Agreed, I don't think this is tremendously helpful given that it does not even tell you what part is incomplete, it's just a broad warning for the entire system. Assuming you have a clock provided that can be used to turn clocks off, and you did not boot with 'clk_ignore_unused' set on the kernel command line, then you should discover pretty quickly which driver is not managing the clocks as it should no? -- Florian