mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: <freedreno@lists.freedesktop.org>,
	Rob Clark <robdclark@gmail.com>, "Sean Paul" <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	"David Airlie" <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>, <quic_jesszhan@quicinc.com>,
	<swboyd@chromium.org>, <dianders@chromium.org>,
	<neil.armstrong@linaro.org>, <andersson@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm/dp: enable widebus on all relevant chipsets
Date: Tue, 30 Jul 2024 12:54:28 -0700	[thread overview]
Message-ID: <872449ad-987a-4e15-bfb0-bf5572cf9302@quicinc.com> (raw)
In-Reply-To: <xmkcy7xjoaodxnyzbskjb7y5xne444qx4jdrtcgoqwh45aqjn2@4rnbkhr5uuby>



On 7/13/2024 3:55 PM, Dmitry Baryshkov wrote:
> On Thu, Jul 11, 2024 at 03:48:50PM GMT, Abhinav Kumar wrote:
>> Hardware document indicates that widebus is recommended on DP on all
>> MDSS chipsets starting version 5.x.x and above.
>>
>> Follow the guideline and mark widebus support on all relevant
>> chipsets for DP.
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> ---
>>   drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
> 
> Although it doesn't seem to fix the 4k screen corruption, I think it's
> still a proper patch (and we should be following hardware
> documentation).
> 
> With the Fixes tags in place:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 

Thanks, I have added the Fixes tags and re-pushed.

I have added only sm8650's tag and another change which re-used sc7180's 
dp_descs without retaining the widebus_supported bit.

The reason I didnt add others is because widebus support itself was 
added only later to DP driver compared to the other ones.

If I am missing any Fixes tag, pls let me know and I can fix it while 
applying.

      reply	other threads:[~2024-07-30 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 22:48 Abhinav Kumar
2024-07-13 22:55 ` Dmitry Baryshkov
2024-07-30 19:54   ` Abhinav Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=872449ad-987a-4e15-bfb0-bf5572cf9302@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®