From: neil.armstrong@linaro.org
To: Doug Anderson <dianders@chromium.org>,
Tejas Vipin <tejasvipin76@gmail.com>
Cc: quic_jesszhan@quicinc.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions
Date: Sun, 23 Jun 2024 18:08:14 +0200 [thread overview]
Message-ID: <8729845e-00f5-4bdd-9804-ddb76913904a@linaro.org> (raw)
In-Reply-To: <CAD=FV=Vpb2xy68LUT9MRi2d=Lze=5AyPjV-ff5FLW30Q6MasJQ@mail.gmail.com>
On 20/06/2024 21:18, Doug Anderson wrote:
> Hi,
>
> On Thu, Jun 20, 2024 at 11:12 AM Tejas Vipin <tejasvipin76@gmail.com> wrote:
>>
>> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi:
>> Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
>> ("drm/mipi-dsi: wrap more functions for streamline handling") for the
>> raydium-rm692e5 panel.
>>
>> Additionally, the error handling in rm692e5_prepare() is changed to
>> properly power the panel off in the case of a wider range of
>> initialization commands failing than before.
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>> Signed-off-by: Tejas Vipin <tejasvipin76@gmail.com>
>> ---
>> Changes in v3:
>> - Remove extra blank line
>> - Expanded on error handling functionality in patch notes
>>
>> Changes in v2:
>> - Change rm692e5_on to return void and take mipi_dsi_multi_context
>> as an argument.
>> - Remove unnecessary warnings.
>> - More efficient error handling in rm692e5_prepare
>>
>> v1: https://lore.kernel.org/all/20240615093758.65431-1-tejasvipin76@gmail.com/
>>
>> v2: https://lore.kernel.org/all/20240619033351.230929-1-tejasvipin76@gmail.com/
>> ---
>> drivers/gpu/drm/panel/panel-raydium-rm692e5.c | 238 ++++++++----------
>> 1 file changed, 99 insertions(+), 139 deletions(-)
>
> Thanks! I normally let non-urgent things sit for a week or so before
> applying them, but I'll be on vacation for some of next week and the
> one after. If this is still pending when I get back then I'll try to
> apply it as I'm getting through my inbox, though I'd also be happy if
> someone else (maybe Neil?) wanted to apply it next week.
Enjoy your vacations! I'll handle it.
Thanks,
Neil
>
> -Doug
next prev parent reply other threads:[~2024-06-23 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 18:10 Tejas Vipin
2024-06-20 19:18 ` Doug Anderson
2024-06-23 16:08 ` neil.armstrong [this message]
2024-06-24 9:05 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8729845e-00f5-4bdd-9804-ddb76913904a@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=quic_jesszhan@quicinc.com \
--cc=tejasvipin76@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®