From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849F9C433FE for ; Tue, 15 Nov 2022 08:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236825AbiKOIw1 (ORCPT ); Tue, 15 Nov 2022 03:52:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232394AbiKOIwY (ORCPT ); Tue, 15 Nov 2022 03:52:24 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD238F5B6; Tue, 15 Nov 2022 00:52:23 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id CE50566029B1; Tue, 15 Nov 2022 08:52:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1668502342; bh=/HIRPmCrAbi1g9Wxs/I+JuWDXoQgjWz8G2CL3MrPoHg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZsE348TFM/TKIjHKMzkZkSuv+ntrtq8yL8nArP0zQSIbD3GEFtmgY8ZK/wWr7GSDF YvWIIjA5Aw2Fx0lYcVsMf7cFK5Z53kK5a5QdC3GNafwKXmImMBdflMHAinXS5cLtCJ QJSUf9SmM8PZijlNpiZleCe8DDTnkameOJNs1wdh0QIHotWS0JrbIs98vnZpl4GjHj F0vn3tq5w4g5/kZbsgwQzsFlQ1EYz4QeVDdLWPUwhvq6adUadDJSaOEh0lET/Y5bVc LFMT8euW5koibUeKX97oNvx3mOZhBwPHXudCY5TA/RoSG9YFr5XS0GOH5UF7UmndNM KPmIe7wDs78Yw== Message-ID: <8732f418-a8eb-3cb4-962f-2353fe8d0154@collabora.com> Date: Tue, 15 Nov 2022 09:52:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v4 2/4] arm64: dts: mt8195: Add edptx and dptx nodes Content-Language: en-US To: =?UTF-8?B?UmV4LUJDIENoZW4gKOmZs+afj+i+sCk=?= , "matthias.bgg@gmail.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group References: <20221110063716.25677-1-rex-bc.chen@mediatek.com> <20221110063716.25677-3-rex-bc.chen@mediatek.com> <73e5491a-9720-ea52-48ff-cc506c6dc582@gmail.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 15/11/22 08:58, Rex-BC Chen (陳柏辰) ha scritto: > On Fri, 2022-11-11 at 13:22 +0100, Matthias Brugger wrote: >> >> On 10/11/2022 07:37, Bo-Chen Chen wrote: >>> In MT8195, we use edptx as the internal display interface and use >>> dptx as the external display interface. Therefore, we need to add >>> these nodes to support the internal display and the external >>> display. >>> >>> - Add dp calibration data in the efuse node. >>> - Add edptx and dptx nodes for MT8195. >>> >>> Signed-off-by: Bo-Chen Chen >>> Reviewed-by: AngeloGioacchino Del Regno < >>> angelogioacchino.delregno@collabora.com> >>> --- >>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 25 >>> ++++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> index c380738d10cb..7acbef5a4517 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> @@ -1244,6 +1244,9 @@ >>> reg = <0x189 0x2>; >>> bits = <7 5>; >>> }; >>> + dp_calibration: dp-data@1ac { >>> + reg = <0x1ac 0x10>; >>> + }; >>> }; >>> >>> u3phy2: t-phy@11c40000 { >>> @@ -2205,5 +2208,27 @@ >>> clock-names = "engine", "pixel", "pll"; >>> status = "disabled"; >>> }; >>> + >>> + edp_tx: edp-tx@1c500000 { >>> + compatible = "mediatek,mt8195-edp-tx"; >>> + reg = <0 0x1c500000 0 0x8000>; >>> + nvmem-cells = <&dp_calibration>; >>> + nvmem-cell-names = "dp_calibration_data"; >>> + power-domains = <&spm >>> MT8195_POWER_DOMAIN_EPD_TX>; >>> + interrupts = >> 0>; >>> + max-linkrate-mhz = <8100>; >>> + status = "disabled"; >>> + }; >>> + >>> + dp_tx: dp-tx@1c600000 { >>> + compatible = "mediatek,mt8195-dp-tx"; >>> + reg = <0 0x1c600000 0 0x8000>; >>> + nvmem-cells = <&dp_calibration>; >>> + nvmem-cell-names = "dp_calibration_data"; >>> + power-domains = <&spm >>> MT8195_POWER_DOMAIN_DP_TX>; >>> + interrupts = >> 0>; >>> + max-linkrate-mhz = <8100>; >>> + status = "disabled"; >>> + }; >> >> For some not really obvious reasons we get the following errors with >> make CHECK_DTBS=1 mediatek/mt8195-cherry-tomato-r2.dtb >> >> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb:0:0: >> /soc/edp-tx@1c500000: failed to match any schema with compatible: >> ['mediatek,mt8195-edp-tx'] >> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb:0:0: >> /soc/dp-tx@1c600000: failed to match any schema with compatible: >> ['mediatek,mt8195-dp-tx'] >> >> Can you please see how to fix this. Tested with next-20221111. >> >> Regards, >> Matthias >> > > Hello Matthias, > > I can not reproduce this issue in my local environment, but I am sure > the binding is in kernel master branch (v6.1-rc5): > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml?h=v6.1-rc5 > > It's strange that the message you provided said it can not find any > schema with ['mediatek,mt8195-edp-tx'] and ['mediatek,mt8195-dp-tx']. > Matthias, I can't reproduce that either... perhaps there's something odd that's going on with your environment? Cheers