From: Takashi Iwai <tiwai@suse.de>
To: Chris Chiu <chris.chiu@canonical.com>
Cc: tiwai@suse.com, kailang@realtek.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] ALSA: hda/realtek: Add inverted LED quirk for HP ZBook 8 G2a
Date: Thu, 16 Jul 2026 08:33:56 +0200 [thread overview]
Message-ID: <8733xjwii3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260716023825.387532-1-chris.chiu@canonical.com>
On Thu, 16 Jul 2026 04:38:25 +0200,
Chris Chiu wrote:
>
> HP ZBook 8 G2a 14 and 16 (SSIDs 0x103c:0x8f94, 0x103c:0x8f95) use the
> Realtek ALC245 codec with a TAS2781 amplifier via I2C. They share the same
> hardware configuration as the existing 0x8f40/0x8f41/0x8f42/0x8f62 models
> but have inverted speaker mute LED polarity, so the existing
> ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED quirk drives the LED backwards: off
> when muted and on when unmuted.
>
> Add a dedicated quirk with inverted COEF values. These are speaker-only
> models without an HP pin, so the LED is driven directly through the
> vmaster_mute hook; there is no need to probe the HP pin at runtime since
> the configuration is static and known per SSID.
>
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-07-16 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 2:38 Chris Chiu
2026-07-16 6:33 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8733xjwii3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=chris.chiu@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome