From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 051683A6B7F for ; Thu, 2 Jul 2026 09:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782984229; cv=none; b=iwfsRT8IoYluJDC2Z47JCdMM7J//ASkSZihuUAyGZdOfOsWnvo2sM7YpzjVGeQJDbjxywf+1jw7F6KfKkjUBIIP8gttHvBp94pYm6wjz398DGrkb3iy/FJlPs/KAkCiN5byvOpbf3lDlZ+HvYC3uf2ckfLisWi0S2+r6rtqOEjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782984229; c=relaxed/simple; bh=HDplQmhc0Z1lXW5MkZvhrKeD0BxhB3Cce68Ofb6dNQU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=I8SH5A5OnKcpTJpPLxE1EL2nvnc8qpYfP/057K6uV12ARSgo9etXzsBgihfMXwf0JiajMuqfO+TAL6qy4eN+6k4DRU/gKF3C1ZwelL1a7wUNmkPucDbNegDW+H7vy6w1+jP92HRvkXuGXUjNSGWj2lqqho7ymEzE/BrwTa5eXcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ArDRZeEM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=T9Vp/YQm; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ArDRZeEM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="T9Vp/YQm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782984227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4zTpKuSZrhsxPxzQIZfaOOpTGT1+k7Nb+QD5Zs9kC3Q=; b=ArDRZeEMsM8tWleiE/e6bp/PpjNnkLUzQZGnudVZ44PlqsxnBeL4eFSFlQ9Zaq8ugSu6Ro JcyjA8WiCkv4aD7r1KOQUJtVv0KztqxO+BfgY0DLpsixahO5vDT2/FkMLuSy0rQ6zRPcfj y1PELSB4khV1wSMyawwfOV9MKvzkT+A= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-vpKCH0kmM1SkB2E9Zp1FdQ-1; Thu, 02 Jul 2026 05:23:45 -0400 X-MC-Unique: vpKCH0kmM1SkB2E9Zp1FdQ-1 X-Mimecast-MFC-AGG-ID: vpKCH0kmM1SkB2E9Zp1FdQ_1782984225 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-493a6fe9ebdso9996175e9.0 for ; Thu, 02 Jul 2026 02:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782984224; x=1783589024; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4zTpKuSZrhsxPxzQIZfaOOpTGT1+k7Nb+QD5Zs9kC3Q=; b=T9Vp/YQmUsSL3y7/cf2gCcBxvGOnGLea6yJHUfcyGdBBKEuFT2NxO3pfD1OFBpccSw rWdENE9qyORWegoyfErRS12SdnHaiHC+uDbXJLTRWFUvsPqniAE7qaPFEzkgGDKsTdEF eurT7HZ9Tr4tOdnVP2zOfvFsA07S/KZ76yxR3yZZWndOrj6T7q6nZn7vWCs9i1CvboqR zTMyGNYjW6NoLcXiDlEzb/IBA26UajZcHsxFjDQi8AXiuWzQpuKfxnewE4qtd+4mSN6o spVX5KwsAHDOhWn6/S9NDNZ6Ghqwdf+B0ICSwMG40DzulD/nlTzEBrKUS31Dna2nT5Lt JTQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984224; x=1783589024; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4zTpKuSZrhsxPxzQIZfaOOpTGT1+k7Nb+QD5Zs9kC3Q=; b=W/SLO+DOQ7KhrJ+bW9+5uglhZO96SQZN32EFPlYCq0d3er5xPGhMkiVvXPAdJsa7pH yizUBWKVi3ojGzuSKzNiXGV+1aI9QvNQzG120SKbmOUN/D8luHckP4UArN5usBX8yEAa JvXAxxhtcya9pdpiRaRudCVtndcVupAtiuzLdsSJtJRC6hlAXDoUzcT4W7W+38nrsdc4 aCwTILh15w/szxBoSJM4LBedQgz9kjCNyprwr8RD3AQmf6DrsM0zxmaHIwbxe1K39V+W gBCw2Fs9kEgck5K/tIYdxi976ipjMHK87YpAPt51D6pxDf/kkWNJZN6lbK8sia9c56OP Zfyg== X-Forwarded-Encrypted: i=1; AFNElJ+rxxpZHtWzCYm7876ROzarnFXs8q7yQLwE6B21qNMksg8G/y/nDkFLQ8ySSVsQueGG0CjC41fASWFDFgI=@vger.kernel.org X-Gm-Message-State: AOJu0YwxMg9VwTtMphpg3G9sE97u0X6fx65akE+4wgatJKtKC9xmLUWN 5hwtI8kXp1ao9jtbMd3qLdZbGa3f1e1Ep1WxBKu3eFOPuMwnRxVa9nEajUW3ilTQGFAu1sELNZx oYOXEMQiRV1qtav4H3Kre/da2kNE6DdehWnAcscj/iYts74h9Qds1ZaqoQVQYBuQEIg== X-Gm-Gg: AfdE7cmto/wYJDJsAHPMAdmwpZLpdFH6EauVJ41k40CtvsyiMBbg7B20JeWwHvxAO1z J1AUAZHb2NAA82H6aarqOE++TyOgVEAwRdjX7Z+EFb7ggaLCzdMbeVLA5FGDgeHHA2+Xs9wT2UO mDvvS5SvwT5Gl7GyRdb96ybofFGFC/35CmL81BMvX+GCDYOpwIqXiZn/1cNsWthzNAMZURFBgrS oNYx5g8cVrN1KOopwS49Cpo/7dil3t1PvPPhdv/zGP6x4FdJy7arY2DjqvlonnEWSirrM6B3IRV 7Yp2JUGdurjD03LoXh4VFAghMdzj/QniaN/fyOo0IQyIQ0X8QjsiRETUJYMiXpxtNkyrraSaKSO JB0WdFChLLldym9yBJOaA86tVY1mUtJMnl3VnvyBEpR9MXT1HSGVN8BM0Nzx2bKH7GfG4Mw== X-Received: by 2002:a7b:cd83:0:b0:492:3e44:214b with SMTP id 5b1f17b1804b1-493c2b4fff8mr50363655e9.13.1782984224684; Thu, 02 Jul 2026 02:23:44 -0700 (PDT) X-Received: by 2002:a7b:cd83:0:b0:492:3e44:214b with SMTP id 5b1f17b1804b1-493c2b4fff8mr50363325e9.13.1782984224177; Thu, 02 Jul 2026 02:23:44 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6368f89sm30642055e9.8.2026.07.02.02.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 02:23:43 -0700 (PDT) From: Javier Martinez Canillas To: Diogo Silva , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diogo Silva Subject: Re: [PATCH v3] drm/rockchip: Remove dependency on DRM simple helpers In-Reply-To: <20260608124018.480365-2-diogompaissilva@gmail.com> References: <20260608124018.480365-2-diogompaissilva@gmail.com> Date: Thu, 02 Jul 2026 11:23:41 +0200 Message-ID: <8733y1d9sy.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Diogo Silva writes: Hello Diogo, > Simple KMS helper are deprecated since they only add an intermediate > layer between drivers and the atomic modesetting. > This patch removes the dependency on drm simple helpers from rockchip > DRM drivers. > I think that would be more informative to say something like following: This patch removes the drm_simple_encoder_init() helper usage in the rockchip drivers, by open coding it and using the encoder atomic helpers directly. This is a step to eventually get rid of this simple KMS helper, once all drivers that use it have been converted. > Signed-off-by: Diogo Silva > --- The changes look good to me: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat