From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C133ACA78 for ; Thu, 9 Apr 2026 09:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775726451; cv=none; b=PRVhK223VqXj2RWBww3KDh/Un8+7A4CFKk6tw0/jqggqUIR1sL8S2ML9V/HOXdm9oP7Sgjse3QZAn9PiIy6XGri3WXVDhbygmxdE35DlMYaR2f25Lue7Ss9RCN4u1xUFef6TUh6P2drJQU8br+KeUTZzO2+qjtlIiCH7/J+WsgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775726451; c=relaxed/simple; bh=Ap3/GSo5+I4TSHRW2SgDcYn5NyH9m4Gkcz3TgAL8Gtk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Upo/UDBNMrTkXvzUY04x28fAvIxDjwweuIstbMYpMXsy4Ge+J7H3RUGFO1CIluZ7wZX8LTW4YOxaYCqkKHPrzdv1ndmP+KKmf+Ojqz7VEc+ls5rbNch0t3bLrhYFOXdaXPaYeXiPGG1oh9XxzixYcfryXMODFdX6Zi/NlevWkWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VXtL28QN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=k1iRMmkF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VXtL28QN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="k1iRMmkF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775726443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CbQigwl8IDMuLzMPbB7/RspCPqzOVDhQuvXsBUa4ins=; b=VXtL28QNiiCiAZ0XX51x72nrGUjhHyaAiBjl5i/IZvUX7Svf/fW0tUVO/KrEBT1xNrMXwC e9nNnTkJuLDWhdQCyUiMro+VuNacvMOpShzIA17E91IaHsPTqb7ScqE+JO1qEgXutdzYSE eHNa/0CwUOlM4TZCIQncwFcituEW/y0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-0pkciLLeOpSBog19woTRAQ-1; Thu, 09 Apr 2026 05:20:42 -0400 X-MC-Unique: 0pkciLLeOpSBog19woTRAQ-1 X-Mimecast-MFC-AGG-ID: 0pkciLLeOpSBog19woTRAQ_1775726441 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43b8f9374dfso330509f8f.0 for ; Thu, 09 Apr 2026 02:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775726441; x=1776331241; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=CbQigwl8IDMuLzMPbB7/RspCPqzOVDhQuvXsBUa4ins=; b=k1iRMmkFu2keiLuVyPVlEcxedTnq7sdrXEUSUH910eSJom5oGok6L1Dunh6wYdmCXO ElgP6MeUlX74SuDiHXIhaQH7bsvF6tvyjoRMgglfmqwXbqAwwnxe0rMmSmEZauJ9TFbM f9Js/oPHOSQ9IJo5Q/leFq8wTNLzZqA0advkJzj7r9801QqNt7GE4l83nsDGAswhc6D2 bhRJrXLESy3Lflpspn5yDEExf5fZ3RJ2rJGCEq3zJ31geFjKi3CA9PGfyCuTUScSSJcx inEAvlJqB8ZkYHzGr/Ah1/YY3EtjOYXJJ5FbbPasD1/5mmg/YTVAtPoZXqYZJgFiLe/K GQ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775726441; x=1776331241; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CbQigwl8IDMuLzMPbB7/RspCPqzOVDhQuvXsBUa4ins=; b=sIh+bcbxms7JYnNtMnC6WScOTgryr/ir7WSTmgbn5DZLWpN7i851ZvNywCiRBs8vDK hwsrnVLLoFfbBH/jyYVIoPYSnKE3y6qyFbTcJZZ7PQtd+Jglgts78CEs4zRS3eyBTJiK lPnw+Qr75lNx2ukd5Us49p8VOISceliIFmpCT4VCllTvw0++5RpaT9BnztGmSrLOYUmh E82qUOjrCpzgXKk2tT8Sm3bWNsA/4lGOfhi5CWGUGsnDuKzaW7NqY4br8s01pWvP+5Z4 87gcyK7H4wfQWnD8/hpnjzsRsLMfsJ4kvjaGSqdAmnm7lmBICbGxoGvAtltrJdDI4VZk OsVg== X-Forwarded-Encrypted: i=1; AJvYcCXpF1cOm6oZIS9+fuyhOzoz5XSbmT5+Sf0P4Ji3sHbjeXEEX2bOGqJ2IjmOoeOfsjkC+G3gRYk/EPZys8o=@vger.kernel.org X-Gm-Message-State: AOJu0Yynjx247BUYoHVMvFI/GonIM+L4kpUAbXucaYiWw/4Q/5oK7skg qY26IWV3BN+Q0bZrxpWFSsoEtzZWqh3Wvqjli1ajSy5RCj7yqeiLFLTPjjpdiSIdVj6RUO6Ns40 8AI9nEtVL8KzjH0uUX537weNZf1+7S1btGmvRRWjBXiKpukBD78LZMmUD6hCERR1DyQ== X-Gm-Gg: AeBDieug5jCeTSTatIafiMN1gX6zc+6mKM13+iCce32MLCg3CscaINK+ui766lksune k4T/wDQfSHRexp7a4IIyEqWfIT2hXcQeiWy84vE8WsFpN4N+N7MsrFuaTIRNaZBaLO8JMT/5d1q 2KDm98pK4lUVwHdZ77mDlc9wNO9wLiQVoaht5A17cDkQV3ZSeDXRtIBcXT44Tpdl9Sm+I6Oyd3x ibwjt3TTehcNLWsgwC4RBzKAkxKQJLrhneg8evfWIs3cfAW/xMo7xbWSbmY0VRUCcnyqnxF9JWH rdjOtgVmy63dHwPory9JULY6Ia0mYv6o0g2ImU/O8AgFf4Gs5KvQ1Jfj+HTsnKY1gA3vB0Hsg5D YwgGlgL4GfyooAQe5+EBjYoz61KTPXOduPp+XKDvCgikLT8iXtw== X-Received: by 2002:a05:6000:4014:b0:43c:a352:c366 with SMTP id ffacd0b85a97d-43d595c4f98mr4111482f8f.25.1775726441496; Thu, 09 Apr 2026 02:20:41 -0700 (PDT) X-Received: by 2002:a05:6000:4014:b0:43c:a352:c366 with SMTP id ffacd0b85a97d-43d595c4f98mr4111430f8f.25.1775726441069; Thu, 09 Apr 2026 02:20:41 -0700 (PDT) Received: from localhost ([37.221.85.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4e221bsm62963480f8f.29.2026.04.09.02.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 02:20:40 -0700 (PDT) From: Javier Martinez Canillas To: Dmitry Baryshkov , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cong Yang , Ondrej Jirman , Jagan Teki , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 09/19] drm/panel: himax-hx8394: simplify hx8394_enable() In-Reply-To: <20260401-waveshare-dsi-touch-v1-9-5e9119b5a014@oss.qualcomm.com> References: <20260401-waveshare-dsi-touch-v1-0-5e9119b5a014@oss.qualcomm.com> <20260401-waveshare-dsi-touch-v1-9-5e9119b5a014@oss.qualcomm.com> Date: Thu, 09 Apr 2026 11:20:33 +0200 Message-ID: <873414jxr2.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dmitry Baryshkov writes: > Simplify hx8394_enable() function by using hx8394_disable() instead of > open-coding it and mipi_dsi_msleep() instead of manual checks. > > Signed-off-by: Dmitry Baryshkov > --- Nice cleanup. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat