From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9774F33123C for ; Mon, 15 Dec 2025 09:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765789918; cv=none; b=UXasBWe8hYbFRpcRSN/1AVy0VYGtEciw4RB4u6/7ZaV8YFqID7AT2oE+HwnCeW//RisMh0JMFBLrsYXezSpaeUxQAzbR6rqFLQ5m371+GDfvrvs2GlX1f0ew2b07D6EeDWCMfGSoKio0AQvYnNuxfeLk+zSP7FEtR1yUoj4CHzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765789918; c=relaxed/simple; bh=4pbXi2MxJu1RwKt4VJM0s4lLZbsP/siXSe4DgtkLmDQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=iQeqx+gbhmtgU1wjliLe5EWF/lGSNLU7S5q8hmrO3UqyXBjDGafvIGKG9aU39dTzHJwdryBEMUjD1aMJk/JToidvptsA89uhYblXLfmA1dnCeM11rhFBy7/rmTPHM0AzKW8Mf2H76gF8zRw4qdkrG77BSV5F8e/9cL10AEc1PdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T29YDd1v; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XIZNuXL9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T29YDd1v"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XIZNuXL9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765789915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/7znRiRQKUpHNgkUgSE9cqfHQAsAHKZeX7554LAbmo=; b=T29YDd1v/Q1C7Kz7YWl0b+QK6UwdGofnAtEGfVrRsyb532zcywrkx9td00mFdDG5gYojD3 9yyJllaHaESqkVgR6PVP5awiVrpjy0jG9nOA2ydstjTp9hwZzvqrewqoAl371AHuCF4Uuh ArV9QNiKPQcajo0H8paWz9t5gE/6vNs= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-anhrp2QnPdieWJRgu-S9Jw-1; Mon, 15 Dec 2025 04:11:53 -0500 X-MC-Unique: anhrp2QnPdieWJRgu-S9Jw-1 X-Mimecast-MFC-AGG-ID: anhrp2QnPdieWJRgu-S9Jw_1765789913 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c5d203988so3092498a91.3 for ; Mon, 15 Dec 2025 01:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765789913; x=1766394713; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=v/7znRiRQKUpHNgkUgSE9cqfHQAsAHKZeX7554LAbmo=; b=XIZNuXL9dkfWMJ9IpUFZR8vh8jp4twrf+o8ZDlkom1QIRvwRcJ8R2FsSV2UnaoPvI2 21UFiT5nQ0DYl3DFblGBF3X54Kdt8oalKgr8hKb04LZhFzbmAZIeQN9M5cI+gc/62RYR Jz/5jJYo43t4L0+tyOH8oeN47CSqM2UijIUnH4fzB48Jfpr2XwTQ1FlPXPQVxiTkPJfN OzHhKBVlg82N4/j85RqzooSxlqXqNEHvlkDOgzqy+7ipNie1kBLXmXhcCfXIDrSW8nl0 YOE1s9lnrLZ1ShK3Y/SH1znR8L4EKarg/JD17JQunor2GDjC6e/P7rppoy6fk3ZdvpBx jUQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765789913; x=1766394713; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v/7znRiRQKUpHNgkUgSE9cqfHQAsAHKZeX7554LAbmo=; b=qeYgrBTMVC5m2RLmIEM1OKLw2jgj3dEkKHMP5KEDnk2An72MdQSeOQIdn09UiHQaM1 7t4/M71FbZICaHedyCYfrOZIgKqo2WvmFALnqX61wUwV+MQN8xE7RTysrgVcP3bzH7G8 uu3aynsz1o5JadGNfabrxln2uR4HntnBa/pHe5KDTPGdufMHRw6Rvk5W9jZQMJNcRBRQ S5R+2VPpB5I31EaqYM6+eW5vF3anMSCe2vcWwJsvSEAgZBFq2KJjwE5vd4yXN6g8tRsL R8q/0Llu0BZPJMuEY1VMe8IfpBvXcNXsVOAAY6vX2IHtFdCGVsupDUEAc6/pWw5ZCIDB VKug== X-Forwarded-Encrypted: i=1; AJvYcCUex2JYSOjLGr7Dgp0Xp2QZTQM5bOFPrbskz3SnOsNynfLVH6j0WJAyrGybcrVI0uCPBL0f0dKf3YtVzmc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw95C60wP6B/MRAFo2PtEJmyC/2Bkmdn4PouoyM/MA/UM3cOLEy bcFeAhfvn1OG//LuNVKuts/gFGZoFXsexb3j7EOCo4bfw6XcXqCzn80rxbnaZea+6GcuEO2yWGB kFFuHO6m6LlV3ehjSz0pbB7Rx5eX0BUm+xNl9jXrZVvdLcv7i828SxYuPm1wGd49I9w== X-Gm-Gg: AY/fxX7hpb9rfUgV487N4VsbIz9cF0sAv53Xgtox7AYVSjKm4TbBi3Jq4939RnCafqW ATosqI4eUWA9yNknFMw9xTf37/a9xerI8u0bGyEeuT8IsmMNwN9ADPNQwDs/TOuiXCbUybOV6TR pzm2DGqPf73Z7/L7uu04PFsVmHQcJsUNLUR3CmBZMTwAM1TCeFf9IEAptYKME4pgSLK5vDSeCkp mJc6/3hRTpSxkkiCpa1hXV4uv37tPc5uzLkbPJsEwbKu3YTbzky7maV7R6GOmK57H/HPttd2OQj MvGry0Xbk2DGbnCN988WtXk/Fl44BlcuZm5AQ7EVXjzEs1qxhSlDfPqtrQbPs7/obeGGwPZoIQd +k7b9VOAy86ATYXHZnPFDyjiBG+BIosiQRBLg3uFt X-Received: by 2002:a17:90b:1dc6:b0:32d:db5b:7636 with SMTP id 98e67ed59e1d1-34abd7853bcmr9023046a91.27.1765789912732; Mon, 15 Dec 2025 01:11:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTECPIXEJSfWfEWpun6/ZYANX1Y2IRo/oSMn2EZXan6O3C+WypQqhHZCXqJs4j1s+ZhDba4g== X-Received: by 2002:a17:90b:1dc6:b0:32d:db5b:7636 with SMTP id 98e67ed59e1d1-34abd7853bcmr9023027a91.27.1765789912362; Mon, 15 Dec 2025 01:11:52 -0800 (PST) Received: from localhost ([195.166.127.210]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe216c54sm8349068a91.7.2025.12.15.01.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 01:11:52 -0800 (PST) From: Javier Martinez Canillas To: Marcus Folkesson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Marcus Folkesson Subject: Re: [PATCH RESEND v2 5/6] drm/sitronix/st7571: split up the driver into a common and an i2c part In-Reply-To: <20251202-st7571-split-v2-5-1e537a09e92f@gmail.com> References: <20251202-st7571-split-v2-0-1e537a09e92f@gmail.com> <20251202-st7571-split-v2-5-1e537a09e92f@gmail.com> Date: Mon, 15 Dec 2025 10:11:44 +0100 Message-ID: <87345ckt2n.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Marcus Folkesson writes: > Split up the driver to make it possible to add support for hw interfaces > other than I2C. > > Signed-off-by: Marcus Folkesson > --- [...] > +config DRM_ST7571_I2C > + tristate "DRM support for Sitronix ST7567/ST7571 display panels (I2C)" > + depends on DRM_ST7571 && I2C > + select REGMAP_I2C I think this should only be "select REGMAP", since you are not using the REGMAP I2C support but instead have your own regmap write callback (due the need to I2C_M_IGNORE_NAK). Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat