Re: [PATCH RESEND v3 00/15] Split sphinx call logic from docs Makefile

[Jonathan Corbet <corbet@lwn.net>]

Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> This series does a major cleanup at docs Makefile by moving the
> actual doc build logic to a helper script (scripts/sphinx-build-wrapper).
>
> Such script was written in a way that it can be called either
> directly or via a makefile. When running via makefile, it will
> use GNU jobserver to ensure that, when sphinx-build is
> called, the number of jobs will match at most what it is
> specified by the "-j" parameter.

So I've been playing with these a bit more, still trying to wrap my head
around them.  I do wish that we were somehow ending up with something
simpler than the status quo, but perhaps the problem domain just isn't
that simple.

> The first 3 patches do a cleanup at scripts/jobserver-exec
> and moves the actual code to a library. Such library is used
> by both the jobserver-exec command line and by sphinx-build-wrappper.

These three seem OK, anyway, and could probably go in anytime.

> The change also gets rid of parallel-wrapper.sh, whose
> functions are now part of the wrapper code.
>
> I added two patches at the end adding an extra target: "mandocs".
> The patches came from a series I sent in separate with 2 patches.

As for the rest, a couple of notes from where I am so far:

- The separation of the comments into their own patch is ... a bit
  strange and makes the patches harder to review.  I plan to spend some
  time looking at the end product, but still ...

- Acting on a hint from Akira, I note that "make O=elsewhere htmldocs"
  no longer works - the output goes into Documentation/output
  regardless.  That, I think, needs to be fixed.

Thanks,

jon