From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25A4938F9A for ; Thu, 18 Apr 2024 07:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713424767; cv=none; b=jxmo24DaLlU8lZeehdeBFWk6nIpJPfe/SU4HRKo7uvEVEQzUehepCOUx/CozZX3MlQFD6z995+UBaQCdaQ2ColThXUuOCej/Kel0WDTSoR2dzq068rOgIYEN+SE2KCF7OWsZGKDQayZILuZgWFi91VbgkKFmnjRxcMH8P1A8NNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713424767; c=relaxed/simple; bh=iVNEkWhaYxo85+q/ZaRi29XbrrdDZIdNKqJFHi/EYM4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ZcM8HXxfDWHdRi/G6yf1tVN180YzDDAlTmVGr0PtbClV8AGTlokQshzgRqsg8KEc63kL1U3MedMbBJOg4jC3woJPs3S1fLv/LrMSc3fTw1/PRpF+CeJ1baJRy/yUGXXDGVqpw3Q/ToJKf77+lxWPo2xv9FhitBK9CNcDX6pDgiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u0DL3bwI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u0DL3bwI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B369AC113CC; Thu, 18 Apr 2024 07:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713424765; bh=iVNEkWhaYxo85+q/ZaRi29XbrrdDZIdNKqJFHi/EYM4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u0DL3bwIiqjxY7xLQmaSPLc4XsT2YoTyGLc68yDk5pHZyGvT3WqLHIdAvRIIUl3PS 7TNRFxfQj/vColwkosB7T5H8+4V2eVMYpe8rFJNqp3DgbnjMRopc56KHeSHHvlNKen E4vIbyc9RpLS52iShpaeFM2BVaiJ7i0cQwHDm0DaHllrTw+sOVSB9C0ymsNBy3ZmfI Ss6vVRQ40UJSQdJO1UMGtBRYftDQccXfK1u2Hur5x8Hs8yskjnegFE3hZRDBSP95wC 0uscDyNsbn9m/JL8D48UXAQzg8gz3ezH4Ig419hc5F6agHv0Z1cFaHU0TubyhBfGsF 116+QCViAV0Lw== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rxM3G-005e59-F5; Thu, 18 Apr 2024 08:19:23 +0100 Date: Thu, 18 Apr 2024 08:18:59 +0100 Message-ID: <8734rjrvdo.wl-maz@kernel.org> From: Marc Zyngier To: tglx@linutronix.de, Guanrui Huang Cc: yuzenghui@huawei.com, shannon.zhao@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] irqchip/gic-v3-its: Fix double free on error In-Reply-To: <20240418061053.96803-1-guanrui.huang@linux.alibaba.com> References: <20240418061053.96803-1-guanrui.huang@linux.alibaba.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: tglx@linutronix.de, guanrui.huang@linux.alibaba.com, yuzenghui@huawei.com, shannon.zhao@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 18 Apr 2024 07:10:51 +0100, Guanrui Huang wrote: > > Hello everyone, this is the v5 of the patch to fix double free > in gic driver. > > The differences from the v3 and v4: > 1. modify description: add "Fixes" in patch 1, as suggested by Markus Elfring. > > 2. improve patch granularity: split 'remove BUG_ON' into a secord patch, > as suggested by Zenghui and Markus Elfring. > > 3. modify description: explain why the BUG_ON is useless in patch 2, > as suggested by Marc Zyngier. > > Thanks, > Guanrui > > Guanrui Huang (2): > irqchip/gic-v3-its: Fix double free on error > irqchip/gic-v3-its: remove BUG_ON in its_vpe_irq_domain_alloc > > drivers/irqchip/irq-gic-v3-its.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > Thomas, can you please take this in for 6.10? Thanks, M. -- Without deviation from the norm, progress is not possible.