From: "Huang, Ying" <ying.huang@intel.com>
To: Chris Li <chriscli@google.com>
Cc: Yosry Ahmed <yosryahmed@google.com>,
Zhongkun He <hezhongkun.hzk@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm:zswap: fix zswap entry reclamation failure in two scenarios
Date: Mon, 20 Nov 2023 11:18:24 +0800 [thread overview]
Message-ID: <8734x1cdtr.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <CAF8kJuOC30feLGs0bNHOxMjSZ3uqF1y7eUdJ4p-w-myP8c1cFg@mail.gmail.com> (Chris Li's message of "Thu, 16 Nov 2023 12:30:20 -0800")
Chris Li <chriscli@google.com> writes:
> On Thu, Nov 16, 2023 at 12:19 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>>
>> Not bypassing the swap slot cache, just make the callbacks to
>> invalidate the zswap entry, do memg uncharging, etc when the slot is
>> no longer used and is entering the swap slot cache (i.e. when
>> free_swap_slot() is called), instead of when draining the swap slot
>> cache (i.e. when swap_range_free() is called). For all parts of MM
>> outside of swap, the swap entry is freed when free_swap_slot() is
>> called. We don't free it immediately because of caching, but this
>> should be transparent to other parts of MM (e.g. zswap, memcg, etc).
>
> That will cancel the batching effect on the swap slot free, making the
> common case for swapping faults take longer to complete, righ?
> If I recall correctly, the uncharge is the expensive part of the swap
> slot free operation.
> I just want to figure out what we are trading off against. This is not
> one side wins all situations.
Per my understanding, we don't batch memcg uncharging in
swap_entry_free() now. Although it's possible and may improve
performance.
--
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2023-11-20 3:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 13:06 Zhongkun He
2023-11-13 15:11 ` Nhat Pham
2023-11-14 5:21 ` [External] " 贺中坤
2023-11-14 16:30 ` Nhat Pham
2023-11-15 12:12 ` 贺中坤
2023-11-14 17:16 ` Yosry Ahmed
2023-11-15 12:53 ` [External] " 贺中坤
2023-11-15 20:12 ` Yosry Ahmed
2023-11-16 3:33 ` 贺中坤
2023-11-16 4:09 ` Yosry Ahmed
2023-11-16 4:23 ` 贺中坤
2023-11-16 8:31 ` Huang, Ying
2023-11-16 10:34 ` [External] " 贺中坤
2023-11-16 20:11 ` Chris Li
2023-11-16 20:18 ` Yosry Ahmed
2023-11-16 20:30 ` Chris Li
2023-11-16 20:45 ` Yosry Ahmed
2023-11-17 23:30 ` Chris Li
2023-11-17 9:56 ` [External] " Zhongkun He
2023-11-17 23:47 ` Chris Li
2023-11-18 1:45 ` Zhongkun He
2023-11-18 18:43 ` Nhat Pham
2023-11-19 8:29 ` Chris Li
2023-11-20 2:42 ` Zhongkun He
2023-11-19 8:23 ` Chris Li
2023-11-20 3:16 ` Zhongkun He
2023-11-20 3:18 ` Huang, Ying [this message]
2023-11-20 5:31 ` Chris Li
2023-11-20 5:39 ` Huang, Ying
2023-11-20 5:51 ` Chris Li
2023-11-20 18:52 ` Yosry Ahmed
2023-11-21 0:54 ` Huang, Ying
2023-11-21 1:15 ` Yosry Ahmed
2023-11-21 1:53 ` Huang, Ying
2023-11-21 2:46 ` Yosry Ahmed
2023-11-21 3:32 ` Huang, Ying
2023-11-21 3:37 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734x1cdtr.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=hezhongkun.hzk@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®