mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcmtest: Extend error injection, decrease buffer filling overhead
Date: Thu, 13 Jul 2023 08:03:00 +0200	[thread overview]
Message-ID: <87351sgxgr.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230712191325.8791-1-ivan.orlov0322@gmail.com>

On Wed, 12 Jul 2023 21:13:25 +0200,
Ivan Orlov wrote:
> 
> Extend 'pcmtest' virtual driver with 'open' callback error injection
> functionality, as it already can inject errors into other PCM callbacks.
> 
> Fix the driver to use already defined variables where it is possible.
> 
> Additionally, decrease the buffer filling overhead with conditional
> reminder calculation in the 'inc_buf_pos' inline function.
> 
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>

Please avoid mixing different changes in a single patch.

This patch does three completely different things, and they should be
split. 

- New inject_open_err parameter
- Optimization of inc_buf_pos()
- Optimization of check_buf_block_ni() and fill_block_pattern_n()

The latter two could be put in a single patch as minor optimizations,
but the introduction of a new option doesn't fit with the rest.


thanks,

Takashi

  reply	other threads:[~2023-07-13  6:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 19:13 Ivan Orlov
2023-07-13  6:03 ` Takashi Iwai [this message]
2023-07-13  7:48   ` Ivan Orlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87351sgxgr.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=ivan.orlov0322@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®