From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60646C77B75 for ; Wed, 17 May 2023 20:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbjEQU2c (ORCPT ); Wed, 17 May 2023 16:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbjEQU2b (ORCPT ); Wed, 17 May 2023 16:28:31 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47B011FFA for ; Wed, 17 May 2023 13:28:30 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E302B22665; Wed, 17 May 2023 20:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684355307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TsMoPVln3DJjIjic43H/HtxMvkVu6MN2Vg/Yi5CKxAc=; b=lobWVl+tPn6RYkrzquAbpPUUU+0Xz3FGiQpyqiBgi6fEB88yTOvwta18Ms+4tl7A2QTPRX B4ZuDUgOAEqOvEe4RVMEqqo2x8IcneYnAawRHzVJ/RMX8F2DbHJ0fc7W8iNuSkAPj45lm+ yZxF+FLgC6p0jHke+Snk3j6H/onTfYU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684355307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TsMoPVln3DJjIjic43H/HtxMvkVu6MN2Vg/Yi5CKxAc=; b=fyGYrSMmNoM1O7B5tvabbnmyStk5593LkcVqzur8fCsa9p7ej8JQ5PgkeHpVUVWRbEbxeK mACeXQJmqBjcJICw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 582BB13478; Wed, 17 May 2023 20:28:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3k41FOs4ZWSQCAAAMHmgww (envelope-from ); Wed, 17 May 2023 20:28:27 +0000 Date: Wed, 17 May 2023 22:28:26 +0200 Message-ID: <87353u1z4l.wl-tiwai@suse.de> From: Takashi Iwai To: Arnd Bergmann Cc: Jaroslav Kysela , Takashi Iwai , Oswald Buddenhagen , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: emu10k1: fix 64-bit integer division In-Reply-To: <20230517201920.592909-1-arnd@kernel.org> References: <20230517201920.592909-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 May 2023 22:19:17 +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > Division of 64-bit values causes a link failure on 32-bit targets, depending > on compiler version and target architecture: > > ERROR: modpost: "__divdi3" [sound/pci/emu10k1/snd-emu10k1.ko] undefined! > ERROR: modpost: "__udivdi3" [sound/pci/emu10k1/snd-emu10k1.ko] undefined! > > Replace these with the safe div_u64() helpers. > > Fixes: bb5ceb43b7bf ("ALSA: emu10k1: fix non-zero mixer control defaults in highres mode") > Signed-off-by: Arnd Bergmann Another fix patch was already submitted and merged: https://lore.kernel.org/r/20230517164800.3650699-1-oswald.buddenhagen@gmx.de Let me know if you still hit the issue with that patch. thanks, Takashi