From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E8EC19F2D for ; Tue, 9 Aug 2022 10:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242117AbiHIKRA (ORCPT ); Tue, 9 Aug 2022 06:17:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242079AbiHIKQ6 (ORCPT ); Tue, 9 Aug 2022 06:16:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C9B918B06 for ; Tue, 9 Aug 2022 03:16:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91D2F60F5B for ; Tue, 9 Aug 2022 10:16:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E30A2C433D6; Tue, 9 Aug 2022 10:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660040215; bh=MndeUiRCpM1SoG5NJpecO2RCFT816htp4Wq9P2IRXVk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tErNOadO1Z/a5hJD3uEhb8cIMFwUoeK9foRKT7Ml09F3dfdrPV25NCOk2edX8qpZg xbb7DTtD7XNVGfjOVdF2f00pNHEVMmDVnurWRdD+D97Aq2/K8SZTlscKw0oddBsR+l tCRYpdQJ0tfMXWIK77iV1TFXOo7A5MVE/Zga3TqjdPUfnoIbh8JNINWbLoICRFCn5A /SuhchjL3bzry/x6n8nTk6e8Wmug/9Y5i7Hg2Qphq5nnoEE3e7pW3X2DWcM/0dc6oe p5T0Ze6fBVfXs1bo0UlgPmGRsz7UemfQ0fCHr7t7IautcnvaI6phWBHvz3P+twfQBH HuiJzZ9xdbGBg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oLMI9-001tBN-IX; Tue, 09 Aug 2022 11:16:53 +0100 Date: Tue, 09 Aug 2022 11:16:53 +0100 Message-ID: <8735e5wwkq.wl-maz@kernel.org> From: Marc Zyngier To: Yang Yingliang Cc: , , Subject: Re: [PATCH] KVM: arm64: fix compile error because of shift overflow In-Reply-To: <20220809094158.4080636-1-yangyingliang@huawei.com> References: <20220809094158.4080636-1-yangyingliang@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yangyingliang@huawei.com, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yang, In the future, please add all the KVM/arm64 reviewers mentioned in MAINTAINERS when sending KVM/arm64 patches. On Tue, 09 Aug 2022 10:41:58 +0100, Yang Yingliang wrote: >=20 > Change the mask to unsigned to fix the following fix compile error > because of shift overflow when using low verison gcc(mine version is 7.5): >=20 > In function =E2=80=98kvm_vm_ioctl_set_device_addr.isra.38=E2=80=99, > inlined from =E2=80=98kvm_arch_vm_ioctl=E2=80=99 at arch/arm64/kvm/ar= m.c:1454:10: > ././include/linux/compiler_types.h:354:38: error: call to =E2=80=98__comp= iletime_assert_599=E2=80=99 \ > declared with attribute error: FIELD_GET: mask is not constant > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) >=20 > Fixes: 9f968c9266aa ("KVM: arm64: vgic-v2: Add helper for legacy dist/cpu= if base address setting") > Signed-off-by: Yang Yingliang > --- > arch/arm64/include/uapi/asm/kvm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/= asm/kvm.h > index 3bb134355874..04ffa13d5e0a 100644 > --- a/arch/arm64/include/uapi/asm/kvm.h > +++ b/arch/arm64/include/uapi/asm/kvm.h > @@ -77,7 +77,7 @@ struct kvm_regs { > #define KVM_ARM_DEVICE_TYPE_SHIFT 0 > #define KVM_ARM_DEVICE_TYPE_MASK (0xffff << KVM_ARM_DEVICE_TYPE_SHIFT) > #define KVM_ARM_DEVICE_ID_SHIFT 16 > -#define KVM_ARM_DEVICE_ID_MASK (0xffff << KVM_ARM_DEVICE_ID_SHIFT) > +#define KVM_ARM_DEVICE_ID_MASK (0xffffu << KVM_ARM_DEVICE_ID_SHIFT) I'd rather you use GENMASK() for this, making it completely unambiguous (and for KVM_ARM_DEVICE_TYPE_MASK as well). Thanks, M. --=20 Without deviation from the norm, progress is not possible.