mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: santoshkumar.yadav@barco.com, peter.korsgaard@barco.com,
	hdegoede@redhat.com, markgross@kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] platform: x86: Remove duplicated include in barco-p50-gpio.c
Date: Sun, 26 Jun 2022 21:11:18 +0200	[thread overview]
Message-ID: <8735fr1bqh.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <YriUMDJoip0Mknh3@Sauravs-MacBook-Air.local> (Saurav Girepunje's message of "Sun, 26 Jun 2022 22:45:28 +0530")

>>>>> "Saurav" == Saurav Girepunje <saurav.girepunje@gmail.com> writes:

 > Remove the duplicate include of linux/io.h in barco-p50-gpio.c
 > file.

 > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

What tree is this against? The io.h include in the line just above
delay.h was already removed by:

commit 011881b80ebe773914b59905bce0f5e0ef93e7ba
Author: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Date:   Thu May 26 17:03:45 2022 +0800

    platform/x86: barco-p50-gpio: Add check for platform_driver_register

    As platform_driver_register() could fail, it should be better
    to deal with the return value in order to maintain the code
    consisitency.

    Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
    Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@iscas.ac.cn
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>

> ---
 >  drivers/platform/x86/barco-p50-gpio.c | 1 -
 >  1 file changed, 1 deletion(-)

 > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
 > index f5c72e33f9ae..bb8ed8e95225 100644
 > --- a/drivers/platform/x86/barco-p50-gpio.c
 > +++ b/drivers/platform/x86/barco-p50-gpio.c
 > @@ -14,7 +14,6 @@
 >  #include <linux/delay.h>
 >  #include <linux/dmi.h>
 >  #include <linux/err.h>
 > -#include <linux/io.h>
 >  #include <linux/kernel.h>
 >  #include <linux/leds.h>
 >  #include <linux/module.h>
 > --
 > 2.33.0


-- 
Bye, Peter Korsgaard

  reply	other threads:[~2022-06-26 19:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 17:15 Saurav Girepunje
2022-06-26 19:11 ` Peter Korsgaard [this message]
2022-06-27  3:39   ` Saurav Girepunje
2022-06-27  7:02     ` Peter Korsgaard
2022-06-27 17:35       ` Saurav Girepunje

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735fr1bqh.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=peter.korsgaard@barco.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=santoshkumar.yadav@barco.com \
    --cc=saurav.girepunje@gmail.com \
    --cc=saurav.girepunje@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®