From: Kalle Valo <kvalo@codeaurora.org>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: Michael Buesch <m@bues.ch>,
linux-wireless@vger.kernel.org (open list:SONICS SILICON
BACKPLANE DRIVER (SSB)), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] Drivers: ssb: remove unnecessary CONFIG_PM_SLEEP
Date: Sat, 07 Nov 2020 17:45:47 +0200 [thread overview]
Message-ID: <87361l6uhg.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <20201029075430.228760-1-coiby.xu@gmail.com> (Coiby Xu's message of "Thu, 29 Oct 2020 15:54:30 +0800")
Coiby Xu <coiby.xu@gmail.com> writes:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
> drivers/ssb/pcihost_wrapper.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/ssb/pcihost_wrapper.c b/drivers/ssb/pcihost_wrapper.c
> index 410215c16920..6510f57469a0 100644
> --- a/drivers/ssb/pcihost_wrapper.c
> +++ b/drivers/ssb/pcihost_wrapper.c
> @@ -18,7 +18,6 @@
> #include <linux/ssb/ssb.h>
>
>
> -#ifdef CONFIG_PM_SLEEP
> static int ssb_pcihost_suspend(struct device *d)
> {
> struct pci_dev *dev = to_pci_dev(d);
> @@ -62,8 +61,6 @@ static const struct dev_pm_ops ssb_pcihost_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(ssb_pcihost_suspend, ssb_pcihost_resume)
> };
>
> -#endif /* CONFIG_PM_SLEEP */
> -
> static int ssb_pcihost_probe(struct pci_dev *dev,
> const struct pci_device_id *id)
> {
> @@ -125,9 +122,7 @@ int ssb_pcihost_register(struct pci_driver *driver)
> {
> driver->probe = ssb_pcihost_probe;
> driver->remove = ssb_pcihost_remove;
> -#ifdef CONFIG_PM_SLEEP
> driver->driver.pm = &ssb_pcihost_pm_ops;
> -#endif
>
> return pci_register_driver(driver);
> }
I'm not convinced that this is correct. How have you confirmed that
there are no compiler or sparse warnings?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-11-07 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 7:54 Coiby Xu
2020-11-07 15:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87361l6uhg.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=coiby.xu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®