From: ebiederm@xmission.com (Eric W. Biederman)
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] proc: Remove the now unnecessary internal mount of proc
Date: Fri, 28 Feb 2020 22:49:15 -0600 [thread overview]
Message-ID: <8736auov5g.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <202002291137.px8YXKJI%lkp@intel.com> (kbuild test robot's message of "Sat, 29 Feb 2020 11:25:27 +0800")
kbuild test robot <lkp@intel.com> writes:
> Hi "Eric,
>
> Thank you for the patch! Yet something to improve:
Dear kbuild robot,
Yep. You got it the wrong base. I will see about using --base
if I repost, or have another patchset that so clearly needs
to be applied on top of a non-default base.
Thank you for writing me how to do that.
Eric
> [auto build test ERROR on uml/linux-next]
> [also build test ERROR on linux/master kees/for-next/pstore linus/master v5.6-rc3 next-20200228]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Eric-W-Biederman/proc-Actually-honor-the-mount-options/20200229-100926
> base: https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next
> config: x86_64-defconfig (attached as .config)
> compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> fs/proc/base.c: In function 'proc_flush_task':
>>> fs/proc/base.c:3217:33: error: 'struct pid_namespace' has no member named 'proc_mnt'; did you mean 'proc_self'?
> proc_flush_task_mnt(upid->ns->proc_mnt, upid->nr,
> ^~~~~~~~
> proc_self
>
> vim +3217 fs/proc/base.c
>
> ^1da177e4c3f41 Linus Torvalds 2005-04-16 3180
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3181 /**
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3182 * proc_flush_task - Remove dcache entries for @task from the /proc dcache.
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3183 * @task: task that should be flushed.
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3184 *
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3185 * When flushing dentries from proc, one needs to flush them from global
> 60347f6716aa49 Pavel Emelyanov 2007-10-18 3186 * proc (proc_mnt) and from all the namespaces' procs this task was seen
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3187 * in. This call is supposed to do all of this job.
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3188 *
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3189 * Looks in the dcache for
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3190 * /proc/@pid
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3191 * /proc/@tgid/task/@pid
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3192 * if either directory is present flushes it and all of it'ts children
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3193 * from the dcache.
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3194 *
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3195 * It is safe and reasonable to cache /proc entries for a task until
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3196 * that task exits. After that they just clog up the dcache with
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3197 * useless entries, possibly causing useful dcache entries to be
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3198 * flushed instead. This routine is proved to flush those useless
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3199 * dcache entries at process exit time.
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3200 *
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3201 * NOTE: This routine is just an optimization so it does not guarantee
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3202 * that no dcache entries will exist at process exit time it
> 0895e91d60ef9b Randy Dunlap 2007-10-21 3203 * just makes it very unlikely that any will persist.
> 60347f6716aa49 Pavel Emelyanov 2007-10-18 3204 */
> 60347f6716aa49 Pavel Emelyanov 2007-10-18 3205
> 60347f6716aa49 Pavel Emelyanov 2007-10-18 3206 void proc_flush_task(struct task_struct *task)
> 60347f6716aa49 Pavel Emelyanov 2007-10-18 3207 {
> 9fcc2d15b14894 Eric W. Biederman 2007-11-14 3208 int i;
> 9b4d1cbef8f41a Oleg Nesterov 2009-09-22 3209 struct pid *pid, *tgid;
> 130f77ecb2e7d5 Pavel Emelyanov 2007-10-18 3210 struct upid *upid;
> 130f77ecb2e7d5 Pavel Emelyanov 2007-10-18 3211
> 130f77ecb2e7d5 Pavel Emelyanov 2007-10-18 3212 pid = task_pid(task);
> 130f77ecb2e7d5 Pavel Emelyanov 2007-10-18 3213 tgid = task_tgid(task);
> 9fcc2d15b14894 Eric W. Biederman 2007-11-14 3214
> 9fcc2d15b14894 Eric W. Biederman 2007-11-14 3215 for (i = 0; i <= pid->level; i++) {
> 130f77ecb2e7d5 Pavel Emelyanov 2007-10-18 3216 upid = &pid->numbers[i];
> 130f77ecb2e7d5 Pavel Emelyanov 2007-10-18 @3217 proc_flush_task_mnt(upid->ns->proc_mnt, upid->nr,
> 9b4d1cbef8f41a Oleg Nesterov 2009-09-22 3218 tgid->numbers[i].nr);
> 130f77ecb2e7d5 Pavel Emelyanov 2007-10-18 3219 }
> 60347f6716aa49 Pavel Emelyanov 2007-10-18 3220 }
> 60347f6716aa49 Pavel Emelyanov 2007-10-18 3221
>
> :::::: The code at line 3217 was first introduced by commit
> :::::: 130f77ecb2e7d5ac3e53e620f55e374f4a406b20 pid namespaces: make proc_flush_task() actually from entries from multiple namespaces
>
> :::::: TO: Pavel Emelyanov <xemul@openvz.org>
> :::::: CC: Linus Torvalds <torvalds@woody.linux-foundation.org>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2020-02-29 4:51 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 15:05 [PATCH v8 00/11] proc: modernize proc to support multiple private instances Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 01/11] proc: Rename struct proc_fs_info to proc_fs_opts Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 02/11] proc: add proc_fs_info struct to store proc information Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 03/11] proc: move /proc/{self|thread-self} dentries to proc_fs_info Alexey Gladkov
2020-02-10 18:23 ` Andy Lutomirski
2020-02-12 15:00 ` Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 04/11] proc: move hide_pid, pid_gid from pid_namespace " Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid mount options Alexey Gladkov
2020-02-10 18:30 ` Andy Lutomirski
2020-02-12 14:57 ` Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 06/11] proc: support mounting procfs instances inside same pid namespace Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 07/11] proc: flush task dcache entries from all procfs instances Alexey Gladkov
2020-02-10 17:46 ` Linus Torvalds
2020-02-10 19:23 ` Al Viro
2020-02-11 1:36 ` Eric W. Biederman
2020-02-11 4:01 ` Eric W. Biederman
2020-02-12 14:49 ` Alexey Gladkov
2020-02-12 14:59 ` Eric W. Biederman
2020-02-12 17:08 ` Alexey Gladkov
2020-02-12 18:45 ` Linus Torvalds
2020-02-12 19:16 ` Eric W. Biederman
2020-02-12 19:49 ` Linus Torvalds
2020-02-12 20:03 ` Al Viro
2020-02-12 20:35 ` Linus Torvalds
2020-02-12 20:38 ` Al Viro
2020-02-12 20:41 ` Al Viro
2020-02-12 21:02 ` Linus Torvalds
2020-02-12 21:46 ` Eric W. Biederman
2020-02-13 0:48 ` Linus Torvalds
2020-02-13 4:37 ` Eric W. Biederman
2020-02-13 5:55 ` Al Viro
2020-02-13 21:30 ` Linus Torvalds
2020-02-13 22:23 ` Al Viro
2020-02-13 22:47 ` Linus Torvalds
2020-02-14 14:15 ` Eric W. Biederman
2020-02-14 3:48 ` Eric W. Biederman
2020-02-20 20:46 ` [PATCH 0/7] proc: Dentry flushing without proc_mnt Eric W. Biederman
2020-02-20 20:47 ` [PATCH 1/7] proc: Rename in proc_inode rename sysctl_inodes sibling_inodes Eric W. Biederman
2020-02-20 20:48 ` [PATCH 2/7] proc: Generalize proc_sys_prune_dcache into proc_prune_siblings_dcache Eric W. Biederman
2020-02-20 20:49 ` [PATCH 3/7] proc: Mov rcu_read_(lock|unlock) in proc_prune_siblings_dcache Eric W. Biederman
2020-02-20 22:33 ` Linus Torvalds
2020-02-20 20:49 ` [PATCH 4/7] proc: Use d_invalidate " Eric W. Biederman
2020-02-20 22:43 ` Linus Torvalds
2020-02-20 22:54 ` Al Viro
2020-02-20 23:00 ` Linus Torvalds
2020-02-20 23:03 ` Al Viro
2020-02-20 23:39 ` Eric W. Biederman
2020-02-20 20:51 ` [PATCH 5/7] proc: Clear the pieces of proc_inode that proc_evict_inode cares about Eric W. Biederman
2020-02-20 20:52 ` [PATCH 6/7] proc: Use a list of inodes to flush from proc Eric W. Biederman
2020-02-20 20:52 ` [PATCH 7/7] proc: Ensure we see the exit of each process tid exactly once Eric W. Biederman
2020-02-21 16:50 ` Oleg Nesterov
2020-02-22 15:46 ` Eric W. Biederman
2020-02-20 23:02 ` [PATCH 0/7] proc: Dentry flushing without proc_mnt Linus Torvalds
2020-02-20 23:07 ` Al Viro
2020-02-20 23:37 ` Eric W. Biederman
2020-02-24 16:25 ` [PATCH v2 0/6] " Eric W. Biederman
2020-02-24 16:26 ` [PATCH v2 1/6] proc: Rename in proc_inode rename sysctl_inodes sibling_inodes Eric W. Biederman
2020-02-24 16:27 ` [PATCH v2 2/6] proc: Generalize proc_sys_prune_dcache into proc_prune_siblings_dcache Eric W. Biederman
2020-02-24 16:27 ` [PATCH v2 3/6] proc: In proc_prune_siblings_dcache cache an aquired super block Eric W. Biederman
2020-02-24 16:28 ` [PATCH v2 4/6] proc: Use d_invalidate in proc_prune_siblings_dcache Eric W. Biederman
2020-02-24 16:28 ` [PATCH v2 5/6] proc: Clear the pieces of proc_inode that proc_evict_inode cares about Eric W. Biederman
2020-02-24 16:29 ` [PATCH v2 6/6] proc: Use a list of inodes to flush from proc Eric W. Biederman
2020-02-28 20:17 ` [PATCH 0/3] proc: Actually honor the mount options Eric W. Biederman
2020-02-28 20:18 ` [PATCH 1/3] uml: Don't consult current to find the proc_mnt in mconsole_proc Eric W. Biederman
2020-02-28 20:18 ` [PATCH 2/3] uml: Create a private mount of proc for mconsole Eric W. Biederman
2020-02-28 20:30 ` Christian Brauner
2020-02-28 21:28 ` Eric W. Biederman
2020-02-28 21:59 ` Christian Brauner
2020-02-28 20:19 ` [PATCH 3/3] proc: Remove the now unnecessary internal mount of proc Eric W. Biederman
2020-02-28 20:39 ` Christian Brauner
2020-02-28 21:40 ` Eric W. Biederman
2020-02-29 3:25 ` kbuild test robot
2020-02-29 4:49 ` Eric W. Biederman [this message]
2020-03-02 23:01 ` [kbuild-all] " Philip Li
2020-03-12 2:03 ` Li Zhijian
2020-02-29 4:23 ` kbuild test robot
2020-02-28 22:34 ` [PATCH 4/3] pid: Improve the comment about waiting in zap_pid_ns_processes Eric W. Biederman
2020-02-29 2:59 ` Christian Brauner
2020-02-14 3:49 ` [PATCH v8 07/11] proc: flush task dcache entries from all procfs instances Eric W. Biederman
2020-02-12 19:47 ` Al Viro
2020-02-11 22:45 ` Al Viro
2020-02-12 14:26 ` Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 08/11] proc: instantiate only pids that we can ptrace on 'hidepid=4' mount option Alexey Gladkov
2020-02-10 16:29 ` Jordan Glover
2020-02-12 14:34 ` Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 09/11] proc: add option to mount only a pids subset Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 10/11] docs: proc: add documentation for "hidepid=4" and "subset=pidfs" options and new mount behavior Alexey Gladkov
2020-02-10 18:29 ` Andy Lutomirski
2020-02-12 16:03 ` Alexey Gladkov
2020-02-10 15:05 ` [PATCH v8 11/11] proc: Move hidepid values to uapi as they are user interface to mount Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736auov5g.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®