From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
aneesh.kumar@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/15] powerpc/mm: convert Book3E 64 to pte_fragment
Date: Mon, 06 May 2019 21:29:55 +1000 [thread overview]
Message-ID: <8736lryg5o.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <0076ad26-9d0e-e408-3521-b8e17669bb04@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 26/04/2019 à 17:58, Christophe Leroy a écrit :
>> Book3E 64 is the only subarch not using pte_fragment. In order
>> to allow refactorisation, this patch converts it to pte_fragment.
>>
>> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> arch/powerpc/include/asm/mmu_context.h | 6 -----
>> arch/powerpc/include/asm/nohash/64/mmu.h | 4 +++-
>> arch/powerpc/include/asm/nohash/64/pgalloc.h | 33 ++++++++++------------------
>> arch/powerpc/mm/Makefile | 4 ++--
>> arch/powerpc/mm/mmu_context.c | 2 +-
>> 5 files changed, 18 insertions(+), 31 deletions(-)
>>
> [...]
>
>> diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
>> index 3c1bd9fa23cd..138c772d58d1 100644
>> --- a/arch/powerpc/mm/Makefile
>> +++ b/arch/powerpc/mm/Makefile
>> @@ -9,6 +9,7 @@ CFLAGS_REMOVE_slb.o = $(CC_FLAGS_FTRACE)
>>
>> obj-y := fault.o mem.o pgtable.o mmap.o \
>> init_$(BITS).o pgtable_$(BITS).o \
>> + pgtable-frag.o \
>> init-common.o mmu_context.o drmem.o
>> obj-$(CONFIG_PPC_MMU_NOHASH) += mmu_context_nohash.o tlb_nohash.o \
>> tlb_nohash_low.o
>> @@ -17,8 +18,7 @@ hash64-$(CONFIG_PPC_NATIVE) := hash_native_64.o
>> obj-$(CONFIG_PPC_BOOK3E_64) += pgtable-book3e.o
>> obj-$(CONFIG_PPC_BOOK3S_64) += pgtable-hash64.o hash_utils_64.o slb.o \
>> $(hash64-y) mmu_context_book3s64.o \
>> - pgtable-book3s64.o pgtable-frag.o
>> -obj-$(CONFIG_PPC32) += pgtable-frag.o
>> + pgtable-book3s64.o
>
> Looks like the removal of pgtable-frag.o for CONFIG_PPC_BOOK3S_64 didn't
> survive the merge.
Hmm, I don't remember having problems there but clearly something went
wrong.
> Will send a patch to fix that.
Thanks.
cheers
next prev parent reply other threads:[~2019-05-06 11:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 15:57 [PATCH v2 00/15] Refactor pgalloc stuff Christophe Leroy
2019-04-26 15:57 ` [PATCH v2 01/15] powerpc/mm: drop __bad_pte() Christophe Leroy
2019-05-03 6:59 ` Michael Ellerman
2019-04-26 15:58 ` [PATCH v2 02/15] powerpc/mm: define __pud_free_tlb() at all time on nohash/64 Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 03/15] powerpc/mm: convert Book3E 64 to pte_fragment Christophe Leroy
2019-05-06 6:37 ` Christophe Leroy
2019-05-06 11:29 ` Michael Ellerman [this message]
2019-04-26 15:58 ` [PATCH v2 04/15] powerpc/mm: move pgtable_t in asm/mmu.h Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 05/15] powerpc/mm: get rid of nohash/32/mmu.h and nohash/64/mmu.h Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 06/15] powerpc/Kconfig: select PPC_MM_SLICES from subarch type Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 07/15] powerpc/book3e: move early_alloc_pgtable() to init section Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 08/15] powerpc/mm: don't use pte_alloc_kernel() until slab is available on PPC32 Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 09/15] powerpc/mm: inline pte_alloc_one_kernel() and pte_alloc_one() " Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 10/15] powerpc/mm: refactor pte_alloc_one() and pte_free() families definition Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 11/15] powerpc/mm: refactor definition of pgtable_cache[] Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 12/15] powerpc/mm: Only keep one version of pmd_populate() functions on nohash/32 Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 13/15] powerpc/mm: refactor pgtable freeing functions on nohash Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 14/15] powerpc/mm: refactor pmd_pgtable() Christophe Leroy
2019-04-26 15:58 ` [PATCH v2 15/15] powerpc/mm: refactor pgd_alloc() and pgd_free() on nohash Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736lryg5o.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®