From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751769AbdJOJFf (ORCPT ); Sun, 15 Oct 2017 05:05:35 -0400 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:38558 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbdJOJFd (ORCPT ); Sun, 15 Oct 2017 05:05:33 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 15 Oct 2017 11:05:32 +0200 X-ME-IP: 90.55.206.157 From: Robert Jarzmik To: Kees Cook Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Makefile: Another fix for stackprotector _AUTO mode In-Reply-To: <20171015034218.GA57631@beast> (Kees Cook's message of "Sat, 14 Oct 2017 20:42:18 -0700") References: <20171015034218.GA57631@beast> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) X-URL: http://belgarath.falguerolles.org/ Date: Sun, 15 Oct 2017 11:05:27 +0200 Message-ID: <87376kok6g.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > If the compiler didn't support a build mode, the second empty test would > still trip. This moves it to an "else" test for the non-AUTO modes. > > Reported-by: Robert Jarzmik > Signed-off-by: Kees Cook > --- > Robert, can you test this fix? Sure, tested and it works perfectly. Tested-by: Robert Jarzmik And just to be more complete, what happened yesterday was that I wrongly wrote "CROSS_COMPILER=arm-linux-gnueabi-" and not "CROSS_COMPILE=arm-linux-gnueabi-". Normally when I do that kind of mistake, I get a gcc error that my architecture options (-mabi, ...) are not supported. This time I got the stackprotector thing. The good part is that with your patch I see again the gcc warnings I was used too :) Cheers. -- Robert PS: rj@belgarion:~/mio_linux/kernel$ arm-linux-gnueabi-gcc -fstack-protector arm-linux-gnueabi-gcc: fatal error: no input files compilation terminated.