From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751692AbdISRqH (ORCPT ); Tue, 19 Sep 2017 13:46:07 -0400 Received: from canardo.mork.no ([148.122.252.1]:53455 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbdISRqF (ORCPT ); Tue, 19 Sep 2017 13:46:05 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Douglas Anderson Cc: Oliver Neukum , groeck@chromium.org, grundler@chromium.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped" Organization: m References: <20170919161522.995-1-dianders@chromium.org> Date: Tue, 19 Sep 2017 19:45:58 +0200 In-Reply-To: <20170919161522.995-1-dianders@chromium.org> (Douglas Anderson's message of "Tue, 19 Sep 2017 09:15:20 -0700") Message-ID: <87377ioa3t.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8JHkCCQ005988 Douglas Anderson writes: > Every once in a while when my system is under a bit of stress I see > some spammy messages show up in my logs that say: > > kevent X may have been dropped > > As far as I can tell these messages aren't terribly useful. I agree, FWIW. These messages just confuse users for no purpose at all. > + /* If work is already started this will mark it to run again when it > + * finishes; if we already had work pending and it hadn't started > + * yet then that's fine too. > + */ > + schedule_work (&dev->kevent); > + netdev_dbg(dev->net, "kevent %d scheduled\n", work); Or maybe if (schedule_work (&dev->kevent)) netdev_dbg(dev->net, "kevent %d scheduled\n", work); ? Not that I think it matters much. Bjørn