From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbdE3Kzl (ORCPT ); Tue, 30 May 2017 06:55:41 -0400 Received: from ozlabs.org ([103.22.144.67]:50183 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbdE3Kzk (ORCPT ); Tue, 30 May 2017 06:55:40 -0400 From: Michael Ellerman To: Murilo Opsfelder Araujo , linux-kernel@vger.kernel.org Cc: linux-watchdog@vger.kernel.org, Guenter Roeck , Wim Van Sebroeck , linuxppc-dev@lists.ozlabs.org, Murilo Opsfelder Araujo Subject: Re: [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies In-Reply-To: <20170529132628.10803-1-mopsfelder@gmail.com> References: <20170529132628.10803-1-mopsfelder@gmail.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 30 May 2017 20:55:35 +1000 Message-ID: <8737bm62c8.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Murilo Opsfelder Araujo writes: > drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c, > which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without > setting CONFIG_PPC_RTAS throws the following errors: > > ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined! > > This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and > CONFIG_PPC_RTAS was not set. Logs are here: > > http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/ > > This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just > CONFIG_PPC_RTAS, removing COMPILE_TEST entirely. > > Signed-off-by: Murilo Opsfelder Araujo > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Michael Ellerman cheers