From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751203AbdBCQ1b (ORCPT ); Fri, 3 Feb 2017 11:27:31 -0500 Received: from foss.arm.com ([217.140.101.70]:54264 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbdBCQ13 (ORCPT ); Fri, 3 Feb 2017 11:27:29 -0500 From: Punit Agrawal To: Tyler Baicar Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Jonathan \(Zhixiong\) Zhang" Subject: Re: [PATCH] arm64: kconfig: allow support for memory failure handling References: <1485985115-27274-1-git-send-email-tbaicar@codeaurora.org> Date: Fri, 03 Feb 2017 16:27:27 +0000 In-Reply-To: <1485985115-27274-1-git-send-email-tbaicar@codeaurora.org> (Tyler Baicar's message of "Wed, 1 Feb 2017 14:38:35 -0700") Message-ID: <8737fvqlxs.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tyler Baicar writes: > From: "Jonathan (Zhixiong) Zhang" > > If ACPI_APEI and MEMORY_FAILURE is configured, select > ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery > when such memory failure is reported through ACPI APEI. APEI > (ACPI Platform Error Interfaces) provides a means for the > platform to convey error information to the kernel. > > Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support > memory failure recovery attempt. > > Signed-off-by: Jonathan (Zhixiong) Zhang > Signed-off-by: Tyler Baicar > --- > arch/arm64/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index f92778d..4cd12a0 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -15,6 +15,8 @@ config ARM64 > select ARCH_HAS_SG_CHAIN > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > select ARCH_USE_CMPXCHG_LOCKREF > + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE > + select ARCH_SUPPORTS_MEMORY_FAILURE Although enabling support for memory failure handling makes sense in the architecture config, it feels out of place to select ACPI_APEI_MEMORY_FAILURE here. Maybe key it off of CONFIG_APEI? Thanks, Punit > select ARCH_SUPPORTS_ATOMIC_RMW > select ARCH_SUPPORTS_NUMA_BALANCING > select ARCH_WANT_COMPAT_IPC_PARSE_VERSION