mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Michal Nazarewicz <mina86@mina86.com>, Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-stable <stable@vger.kernel.org>,
	"Robin H. Johnson" <robbat2@orbis-terrarum.net>,
	Vlastimil Babka <vbabka@suse.cz>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path.
Date: Thu, 29 Dec 2016 15:17:18 -0800	[thread overview]
Message-ID: <8737h65nr5.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <xa1td1ga74v7.fsf@mina86.com>

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

Michal Nazarewicz <mina86@mina86.com> writes:

> On Thu, Dec 29 2016, Eric Anholt wrote:
>> Michal Hocko <mhocko@kernel.org> writes:
>>
>>> This has been already brought up
>>> http://lkml.kernel.org/r/20161130092239.GD18437@dhcp22.suse.cz and there
>>> was a proposed patch for that which ratelimited the output
>>> http://lkml.kernel.org/r/20161130132848.GG18432@dhcp22.suse.cz resp.
>>> http://lkml.kernel.org/r/robbat2-20161130T195244-998539995Z@orbis-terrarum.net
>>>
>>> then the email thread just died out because the issue turned out to be a
>>> configuration issue. Michal indicated that the message might be useful
>>> so dropping it completely seems like a bad idea. I do agree that
>>> something has to be done about that though. Can we reconsider the
>>> ratelimit thing?
>>
>> I agree that the rate of the message has gone up during 4.9 -- it used
>> to be a few per second.
>
> Sounds like a regression which should be fixed.
>
> This is why I don’t think removing the message is a good idea.  If you
> suddenly see a lot of those messages, something changed for the worse.
> If you remove this message, you will never know.
>
>> However, if this is an expected path during normal operation,
>
> This depends on your definition of ‘expected’ and ‘normal’.
>
> In general, I would argue that the fact those ever happen is a bug
> somewhere in the kernel – if memory is allocated as movable, it should
> be movable damn it!

I was taking "expected" from dae803e165a11bc88ca8dbc07a11077caf97bbcb --
if this is a actually a bug, how do we go about debugging it?

I've had Raspbian carrying a patch downstream to remove the error
message for 2 years now, and I either need to get this fixed or get this
patch merged to Fedora and Debian as well, now that they're shipping
some support for Raspberry Pi.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2016-12-29 23:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-29  2:31 Eric Anholt
2016-12-29  9:12 ` Michal Hocko
2016-12-29 17:27   ` Eric Anholt
2016-12-29 22:22     ` Michal Nazarewicz
2016-12-29 23:17       ` Eric Anholt [this message]
2016-12-30  7:11         ` Michal Nazarewicz
2016-12-30 20:25           ` Eric Anholt
2016-12-31  5:08             ` Michal Nazarewicz
2016-12-30 10:52       ` Michal Hocko
2017-01-02  7:39         ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737h65nr5.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mhocko@kernel.org \
    --cc=mina86@mina86.com \
    --cc=robbat2@orbis-terrarum.net \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®