mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org, Michal Marek <mmarek@suse.cz>
Subject: Re: [lkp] [x86]  784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user
Date: Sun, 09 Oct 2016 11:46:12 +0200	[thread overview]
Message-ID: <8737k5c0t7.fsf@gmail.com> (raw)
In-Reply-To: <20160930092658.0da22cad@canb.auug.org.au>


Hi,

> Do we have any resolution of this?

I got the exact same problem if CONFIG_MODVERSIONS is enabled.
Here is my understanding.

All the symbols exported using assembler macro EXPORT_SYMBOL will need a
__crc_<symbol> to be defined later on (include/asm-generic/export.h).

This is what genksyms should do but it only runs on *.c files. So all the
symbols exported from *.S files won't get crc.

modpost is complaining about missing crc and it will not include those
symbols in *.mod.c modversion_info struct. Then, we got "Unknown
symbol" errors when modules are inserted at runtime.

I fixed it locally by setting __crc_<symbol> to a constant value in
export.h. But it may be a better idea to have genksyms run on *.S files ?

Thanks,

Mathieu

  reply	other threads:[~2016-10-09  9:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20  2:55 kernel test robot
2016-09-29 23:26 ` Stephen Rothwell
2016-10-09  9:46   ` Mathieu OTHACEHE [this message]
2016-10-11 13:10   ` Michal Marek
2016-10-11 13:14     ` Michal Marek
2016-10-14  7:27       ` Mathieu OTHACEHE
2016-10-18  8:00       ` [LKP] " Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737k5c0t7.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mmarek@suse.cz \
    --cc=sfr@canb.auug.org.au \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome