From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751705AbcGYFKQ (ORCPT ); Mon, 25 Jul 2016 01:10:16 -0400 Received: from ozlabs.org ([103.22.144.67]:42817 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbcGYFKK (ORCPT ); Mon, 25 Jul 2016 01:10:10 -0400 From: Michael Ellerman To: chengang@emindsoft.com.cn, akpm@linux-foundation.org, benh@kernel.crashing.org, paulus@samba.org Cc: dave.hansen@linux.intel.com, tglx@linutronix.de, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Chen Gang , Chen Gang Subject: Re: [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot In-Reply-To: <1469331815-2026-1-git-send-email-chengang@emindsoft.com.cn> References: <1469331815-2026-1-git-send-email-chengang@emindsoft.com.cn> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 25 Jul 2016 15:10:06 +1000 Message-ID: <8737my1exd.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org chengang@emindsoft.com.cn writes: > From: Chen Gang > > For pure bool function's return value, bool is a little better more or > less than int. > > Signed-off-by: Chen Gang > --- > arch/powerpc/include/asm/mman.h | 8 ++++---- > include/linux/mman.h | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) LGTM. Acked-by: Michael Ellerman Andrew do you want to take this or should I? cheers