From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755496AbcECTWI (ORCPT ); Tue, 3 May 2016 15:22:08 -0400 Received: from anholt.net ([50.246.234.109]:47226 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbcECTWH (ORCPT ); Tue, 3 May 2016 15:22:07 -0400 From: Eric Anholt To: robert.foss@collabora.com, daniel.vetter@ffwll.ch, airlied@linux.ie, aniel.vetter@ffwll.ch, fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com, julia.lawall@lip6.fr, alexander.deucher@amd.com, daniels@collabora.com, derekf@osg.samsung.com, varadgautam@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Robert Foss Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. In-Reply-To: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> References: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 03 May 2016 12:22:00 -0700 Message-ID: <8737pzlzfr.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain robert.foss@collabora.com writes: > From: Robert Foss > > As per the documentation in drm_crtc.h, atomic_commit should return > -EBUSY if an asycnhronous update is requested and there is an earlier > update pending. > > Note: docs cited here are drm_crtc.h, and the whole quote is: > > * - -EBUSY, if an asynchronous updated is requested and there is > * an earlier updated pending. Drivers are allowed to support a queue > * of outstanding updates, but currently no driver supports that. > * Note that drivers must wait for preceding updates to complete if a > * synchronous update is requested, they are not allowed to fail the > * commit in that case. > > Signed-off-by: Robert Foss This looks good to me. Let's give it a few days on the list for any other KMS folks to catch anything. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXKPpZAAoJELXWKTbR/J7otKoP+wVnr0/UY1rBojTk+NgIXfCq tZAQyRwr2Sqa3drw6Vik9SQVegfwx7nkXp41W0a7rQVZbtnGLch0gXLDqbm7U2zR Qif43wHJQJESa2dXzZVIHpp3gjzQ91pxCvrLvo3iE6gK/C6bGx4nFOPzZu+1ntNO Yg0l7vNV9qgdK+3XUZD5izl1aULIjqmhbQ4Qlv4Q6jNtho1HeZRAibCOX7nIjfsK 6CA18yzQLU/tvIy93XVzFcwC98D/NP1m8gGLHvqQY/P/FWz9geNTRsXE5bwnoEg7 EiJwyOPdDydhQqqLexkFwgiVcLuMKaY6gbZSt9HyNsVGZ9klEaFL/wgaU7kl7ag1 Pg8BBSt/1TkwSPCR0YL3vxXBkugfh7zC0tiFWekAJW73Kg7Wbp9l/UKG0Q+dC5al KJnXtCmKI0Ur30oU5WudSUNt0V9Jrp+eaSqOuWVjaUR/+SJ6uqB1vcunLkR125TI DjKzQMXqcP3ViJmre0lMIGFy4bTTvtJYRxu+9vdulzEPUboMPnUXAeWH5z34ciqI QFT2IdU8SwDOCFQGFx8vG3ePAZYp0Gre909mX5Xg3FHvzDW7YoDb1J/3t9Zs+zCT Op/pejadIS8iKIkHxfF/ZD9QHRBiHv9CAYqMDEDLpNTWfneOPfAjiSSU21Ye8aII UaI0a2USA4NcNzp+Oh42 =Po4G -----END PGP SIGNATURE----- --=-=-=--