From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbbLRRl6 (ORCPT ); Fri, 18 Dec 2015 12:41:58 -0500 Received: from mga01.intel.com ([192.55.52.88]:31142 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbbLRRl5 (ORCPT ); Fri, 18 Dec 2015 12:41:57 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,447,1444719600"; d="scan'208";a="876617218" From: Alexander Shishkin To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, johannes@sipsolutions.net, Arnaldo Carvalho de Melo Subject: Re: [PATCH 2/7] perf: Generalize task_function_call()ers In-Reply-To: <20151218164704.GQ6344@twins.programming.kicks-ass.net> References: <1449138762-15194-1-git-send-email-alexander.shishkin@linux.intel.com> <1449138762-15194-3-git-send-email-alexander.shishkin@linux.intel.com> <20151203173431.GC3816@twins.programming.kicks-ass.net> <87vb88yjs6.fsf@ashishki-desk.ger.corp.intel.com> <20151208165700.GE6357@twins.programming.kicks-ass.net> <20151217134034.GM6373@twins.programming.kicks-ass.net> <87k2odb19x.fsf@ashishki-desk.ger.corp.intel.com> <20151217150732.GG6344@twins.programming.kicks-ass.net> <20151218090129.GQ6373@twins.programming.kicks-ass.net> <87d1u3bxs9.fsf@ashishki-desk.ger.corp.intel.com> <20151218164704.GQ6344@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 18 Dec 2015 19:41:54 +0200 Message-ID: <8737uzy7q5.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Fri, Dec 18, 2015 at 05:07:34PM +0200, Alexander Shishkin wrote: >> Peter Zijlstra writes: >> >> > @@ -2774,9 +2696,6 @@ static void perf_event_context_sched_in( >> > */ >> > cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); >> > >> > - if (ctx->nr_events) >> > - cpuctx->task_ctx = ctx; >> > - >> > perf_event_sched_in(cpuctx, cpuctx->task_ctx, task); >> >> This then should probably become >> >> perf_event_sched_in(cpuctx, ctx, task); >> >> otherwise task contexts just don't get scheduled any more. > > Very good, thanks! > > Running with that triggers another WARN, I'll have a look at that later > tonight. Hmm, is it the one from event_function() where a task context is scheduled, but is inactive and/or doesn't have events? I think there's also more fun to be had there now that you've started digging it up, I'll also poke at it more later today. Regards, -- Alex