From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: isdn: pcbit: another off-by-one issue?
Date: Wed, 10 Jun 2015 21:50:53 +0200 [thread overview]
Message-ID: <87381zqr4y.fsf@rasmusvillemoes.dk> (raw)
Hi Dan
You were last to touch drivers/isdn/pcbit/drv.c (7bcc6738eef), but I
think there may still be an off-by-one in pcbit_set_msn: At the end of
the loop, sp is incremented by len, but if the string contained a comma,
sp will now point at that. At that point, we seem to be stuck in an
infinite loop where we'll always get cp==sp and len==0, until we run out
of memory.
Am I reading this completely wrong?
Rasmus
next reply other threads:[~2015-06-10 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 19:50 Rasmus Villemoes [this message]
2015-06-11 7:58 ` Dan Carpenter
2015-06-11 9:28 ` Rasmus Villemoes
2015-06-11 11:44 ` Paul Bolle
2015-06-30 21:46 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87381zqr4y.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®