From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
"David E. Box" <david.e.box@linux.intel.com>
Cc: irenic.rajneesh@gmail.com, david.e.box@intel.com,
markgross@kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/2] platform/x86/intel/pmt/telemetry: Add driver version
Date: Mon, 20 Mar 2023 15:18:58 +0100 [thread overview]
Message-ID: <87382b5e-f3f8-601c-77ff-ecd44d911042@redhat.com> (raw)
In-Reply-To: <CAHp75VcP5jf4Tt-U7cs77gnTcUpQbQ+exXjOOc5epPRDfT0h0Q@mail.gmail.com>
Hi,
On 3/17/23 14:35, Andy Shevchenko wrote:
> On Fri, Mar 17, 2023 at 12:57 AM David E. Box
> <david.e.box@linux.intel.com> wrote:
>>
>> Add a driver version number to make it easier to track changes in
>> backported kernels.
>
> Sorry, but NAK. As Greg KH said, we do not use this anymore (in Git
> era) — the SHA from the Git _is_ the version of the driver.
I agree with Andy per driver version numbers are really not useful.
Generally speaking the version number will get updated say once
per upstream kernel-release in a separate commit, but there is
no guarantee that commit will get cherry-picked together with
other cherry-picked fixes.
So for downstream kernels these version numbers really don't
have any meaning and as such are useless.
Regards,
Hans
next prev parent reply other threads:[~2023-03-20 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 22:57 [PATCH 1/2] platform/x86/intel/pmt: Add INTEL_PMT module namespace David E. Box
2023-03-16 22:57 ` [PATCH 2/2] platform/x86/intel/pmt/telemetry: Add driver version David E. Box
2023-03-17 13:35 ` Andy Shevchenko
2023-03-20 14:18 ` Hans de Goede [this message]
2023-03-20 17:03 ` David E. Box
2023-03-17 13:34 ` [PATCH 1/2] platform/x86/intel/pmt: Add INTEL_PMT module namespace Andy Shevchenko
2023-03-20 14:16 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87382b5e-f3f8-601c-77ff-ecd44d911042@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=david.e.box@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®