From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754239AbbFAVdj (ORCPT ); Mon, 1 Jun 2015 17:33:39 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:43239 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754052AbbFAVda (ORCPT ); Mon, 1 Jun 2015 17:33:30 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 01 Jun 2015 23:33:23 +0200 X-ME-IP: 109.222.248.120 From: Robert Jarzmik To: Joe Perches Cc: Vinod Koul , Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information References: <1617548760.717381111.1432891749082.JavaMail.root@zimbra1-e1.priv.proxad.net> <1432893073.29807.15.camel@perches.com> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 01 Jun 2015 23:31:48 +0200 In-Reply-To: <1432893073.29807.15.camel@perches.com> (Joe Perches's message of "Fri, 29 May 2015 02:51:13 -0700") Message-ID: <87382bt8sb.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: > Hello Robert. > > The return value of that dbg_show_requester_chan function > was incorrect and the increment of pos was an example of > why the seq_printf return value was changed to void. > > It was a pretty common error and easy to understand given > the expectation that seq_printf should work like printf. Sure. > It's a pity it bit you. but this type of patch collision > should be a bit more difficult to reoccur in the future. I got what I deserved. I knew it was coming, I've seen it in other drivers of mine, but my left brain didn't tell the other half to crosscheck in this patch. Anyway, it's not a big fixup, so everything is fine now. Cheers. -- Robert