From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751478AbaCLEBJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 12 Mar 2014 00:01:09 -0400
Received: from mail-pb0-f48.google.com ([209.85.160.48]:53103 "EHLO
	mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751070AbaCLEBG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 12 Mar 2014 00:01:06 -0400
Date: Tue, 11 Mar 2014 21:01:05 -0700 (PDT)
Message-ID: <8738iorrpd.wl%kuninori.morimoto.gx@gmail.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: Mark Brown <broonie@kernel.org>, <moinejf@free.fr>,
        <alsa-devel@alsa-project.org>, <kuninori.morimoto.gx@renesas.com>,
        <linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
        <Li.Xiubo@freescale.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: simple-card: overwrite DAIFMT_MASTER of	cpu_dai->fmt
In-Reply-To: <20140312032657.GF1177@MrMyself>
References: <1394542472-16580-1-git-send-email-Guangyu.Chen@freescale.com>
	<8761nkryky.wl%kuninori.morimoto.gx@gmail.com>
	<20140312014927.GK28112@sirena.org.uk>
	<874n34rsul.wl%kuninori.morimoto.gx@gmail.com>
	<20140312032657.GF1177@MrMyself>
User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Nicolin

> > static struct asoc_simple_card_info fsi_wm8978_info = {
> > 	...
> > 	.daifmt		= SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM,
> > 	.cpu_dai = {
> > 		...
> > 		.fmt	= SND_SOC_DAIFMT_IB_NF,
> > 	},
> > 	.codec_dai = {
> > 		...
> > 		.fmt	= SND_SOC_DAIFMT_NB_NF,
> > 	},
> > };
> 
> This would be better imo.
> 
> And ideally we should also keep the xB_xF identical like Mark said _identical_.
> Just some cpu dai drivers might do an incorrect settings for it, like regarding
> NB as sampling on rising edge and IF as active low (I'm saying this without a
> careful check though), which results people need to re-set bitclock-invert and
> frame-invert if they switch the DAI format from left_j to i2s for example.

Wow... I had misunderstood...
I need to send fixup patch after lunch.