From: Peter Korsgaard <jacmet@sunsite.dk>
To: Philip Avinash <avinashphilip@ti.com>
Cc: <b-cousson@ti.com>, <tony@atomide.com>, <linux@arm.linux.org.uk>,
<linux-omap@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <nsekhar@ti.com>,
<gururaja.hebbar@ti.com>, <zonque@gmail.com>
Subject: Re: [PATCH 2/3] ARM: dts: AM33XX: Add GPMC node
Date: Mon, 21 Jan 2013 22:01:53 +0100 [thread overview]
Message-ID: <8738xu9rni.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1358491295-4022-3-git-send-email-avinashphilip@ti.com> (Philip Avinash's message of "Fri, 18 Jan 2013 12:11:34 +0530")
>>>>> "Philip" == Philip Avinash <avinashphilip@ti.com> writes:
Philip> From: "Philip, Avinash" <avinashphilip@ti.com>
Philip> Add GPMC data node to AM33XX device tree file.
Philip> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
Philip> ---
Philip> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++
Philip> 1 file changed, 12 insertions(+)
Philip> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
Philip> index eaef5e7..f4209d8 100644
Philip> --- a/arch/arm/boot/dts/am33xx.dtsi
Philip> +++ b/arch/arm/boot/dts/am33xx.dtsi
Philip> @@ -393,5 +393,17 @@
Philip> ti,hwmods = "elm";
Philip> status = "disabled";
Philip> };
Philip> +
Philip> + gpmc: gpmc@50000000 {
Philip> + compatible = "ti,am3352-gpmc";
Philip> + ti,hwmods = "gpmc";
Philip> + reg = <0x50000000 0x2000>;
Philip> + interrupts = <100>;
Philip> + num-cs = <8>;
Next to Jan's comment about am335x having 7 cs signals, I just realized
the difference in compatible string between the gpmc and elm. The gpmc
refers to a real device (which is afaik how it should be done), but the
elm compatible is simply ti,am33xx-elm.
Presumably it should have been ti,am3352-elm in the binding instead?
Other than that it looks fine.
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-01-21 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 6:41 [PATCH 0/3] Add device tree support for NAND flash in am335x-evm Philip Avinash
2013-01-18 6:41 ` [PATCH 1/3] ARM: dts: AM33XX: Add ELM node Philip Avinash
2013-01-21 20:47 ` Peter Korsgaard
2013-01-23 6:32 ` Philip, Avinash
2013-01-18 6:41 ` [PATCH 2/3] ARM: dts: AM33XX: Add GPMC node Philip Avinash
2013-01-18 13:17 ` Jan Lübbe
2013-01-21 21:01 ` Peter Korsgaard [this message]
2013-01-23 6:32 ` Philip, Avinash
2013-01-18 6:41 ` [PATCH 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm Philip Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738xu9rni.fsf@dell.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=avinashphilip@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®