From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: akpm@linux-foundation.org, bfields@fieldses.org,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ravishankar N <ravi.n1@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails
Date: Sat, 13 Oct 2012 23:35:45 +0900 [thread overview]
Message-ID: <87391i8mny.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <CAKYAXd_vWenGBzRoh9cv_Qet_znyPhe_2QpBp29mZJqqoKEFgg@mail.gmail.com> (Namjae Jeon's message of "Sat, 13 Oct 2012 23:03:31 +0900")
Namjae Jeon <linkinjeon@gmail.com> writes:
> 2012/10/13 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
>> Namjae Jeon <linkinjeon@gmail.com> writes:
>>
>>> + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) {
>>> + parent_logstart = fat_get_start(sbi, de);
>>> parent_inode = fat_dget(sb, parent_logstart);
>>> + if (parent_inode || sbi->options.nfs != FAT_NFS_NOSTALE_RO)
>>> + goto out;
>>> + if (!parent_logstart)
>>> + /*logstart of dotdot entry is zero if
>>> + * if the directory's parent is root
>>> + */
>>> + parent_inode = sb->s_root->d_inode;
>>
>> get_parent() should not be called for root dir, right?
> Yes.
Ah, actual question was - subdir of root can be passed to this? I guess
it is possible...
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2012-10-13 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 8:32 Namjae Jeon
2012-10-13 9:27 ` OGAWA Hirofumi
2012-10-13 14:03 ` Namjae Jeon
2012-10-13 14:35 ` OGAWA Hirofumi [this message]
2012-10-13 15:14 ` Namjae Jeon
2012-10-13 16:50 ` OGAWA Hirofumi
2012-10-15 7:28 ` Namjae Jeon
2012-10-15 7:57 ` OGAWA Hirofumi
2012-10-15 13:20 ` Namjae Jeon
2012-10-23 7:34 ` Namjae Jeon
2012-10-23 7:53 ` OGAWA Hirofumi
2012-10-23 11:38 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87391i8mny.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=ravi.n1@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome