From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06242C4321E for ; Wed, 30 Nov 2022 09:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234383AbiK3JA0 (ORCPT ); Wed, 30 Nov 2022 04:00:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235266AbiK3JAS (ORCPT ); Wed, 30 Nov 2022 04:00:18 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8530C421B9; Wed, 30 Nov 2022 01:00:15 -0800 (PST) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 30 Nov 2022 18:00:14 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 951C8205D901; Wed, 30 Nov 2022 18:00:14 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 30 Nov 2022 18:00:14 +0900 Received: from [10.212.156.209] (unknown [10.212.156.209]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 44F7AA855B; Wed, 30 Nov 2022 18:00:14 +0900 (JST) Message-ID: <8739afc1-47c9-3950-e449-ff424820bec9@socionext.com> Date: Wed, 30 Nov 2022 18:00:13 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 3/8] dt-bindings: soc: socionext: Add UniPhier peripheral block Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221129103509.9958-1-hayashi.kunihiko@socionext.com> <20221129103509.9958-4-hayashi.kunihiko@socionext.com> From: Kunihiko Hayashi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2022/11/29 23:46, Krzysztof Kozlowski wrote: > On 29/11/2022 11:35, Kunihiko Hayashi wrote: >> Add devicetree binding schema for the peripheral block implemented on >> Socionext Uniphier SoCs. >> >> Peripheral block implemented on Socionext UniPhier SoCs is an integrated >> component of the peripherals including UART, I2C/FI2C, and SCSSI. >> >> Peripheral block has some function logics to control the component. >> >> Signed-off-by: Kunihiko Hayashi >> --- >> .../socionext,uniphier-perictrl.yaml | 67 +++++++++++++++++++ >> 1 file changed, 67 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml >> new file mode 100644 >> index 000000000000..080b6ab3ea1a >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml >> @@ -0,0 +1,67 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: >> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-perictrl.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Socionext UniPhier peripheral block controller >> + >> +maintainers: >> + - Kunihiko Hayashi >> + >> +description: |+ >> + Peripheral block implemented on Socionext UniPhier SoCs is an >> integrated >> + component of the peripherals including UART, I2C/FI2C, and SCSSI. >> + Peripheral block controller is a logic to control the component. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - socionext,uniphier-ld4-perictrl >> + - socionext,uniphier-pro4-perictrl >> + - socionext,uniphier-pro5-perictrl >> + - socionext,uniphier-pxs2-perictrl >> + - socionext,uniphier-ld6b-perictrl >> + - socionext,uniphier-sld8-perictrl >> + - socionext,uniphier-ld11-perictrl >> + - socionext,uniphier-ld20-perictrl >> + - socionext,uniphier-pxs3-perictrl >> + - socionext,uniphier-nx1-perictrl >> + - socionext,uniphier-perictrl >> + - const: simple-mfd >> + - const: syscon >> + >> + reg: >> + maxItems: 1 >> + >> +patternProperties: >> + "^clock-controller(@[0-9a-f]+)?$": >> + $ref: /schemas/clock/socionext,uniphier-clock.yaml# >> + >> + "^reset-controller(@[0-9a-f]+)?$": >> + $ref: /schemas/reset/socionext,uniphier-reset.yaml# >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + syscon@59820000 { >> + compatible = "socionext,uniphier-ld20-perictrl", >> + "simple-mfd", "syscon"; >> + reg = <0x59820000 0x200>; >> + >> + clock-controller { > > None of your children in examples and in DTS have unit addresses. > However you explicitly mentioned them in the patternProperties. Do you > expect adding unit addresses? Currently, children's registers are partially mixed and it's hard to specify the unit address. The address pattern was added as option for the future, however, not needed for the current implementation. I'll remove them in next. Thank you, --- Best Regards Kunihiko Hayashi