mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Sasha Levin <levinsasha928@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	linux-scsi <linux-scsi@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] virtio-scsi: first version
Date: Fri, 02 Dec 2011 10:59:42 +1030	[thread overview]
Message-ID: <8739d3stmx.fsf@rustcorp.com.au> (raw)
In-Reply-To: <4ED73CA3.5080409@redhat.com>

On Thu, 01 Dec 2011 09:36:51 +0100, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 12/01/2011 07:33 AM, Sasha Levin wrote:
> > On Wed, 2011-11-30 at 14:54 +0100, Paolo Bonzini wrote:
> >> +	/* We need to know how many segments before we allocate.
> >> +         * We need an extra sg elements at head and tail.
> >> +	 */
> >> +	sg_elems = virtscsi_config_get(vdev, seg_max);
> >
> > Maybe default to one if not specified (=0), like in virtio-blk.
> 
> Good idea.  Though with sg_elems=1 it is insanely slow.

And a bit over-conservative.  If they don't specify a max, you can pick
a number.  Make sure it fits in the ring though :)

Thanks,
Rusty.

  parent reply	other threads:[~2011-12-02  1:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 13:54 [PATCH 0/2] virtio-scsi driver Paolo Bonzini
2011-11-30 13:54 ` [PATCH 1/2] virtio-scsi: first version Paolo Bonzini
2011-12-01  6:33   ` Sasha Levin
2011-12-01  8:36     ` Paolo Bonzini
2011-12-01  8:55       ` Sasha Levin
2011-12-02  0:29       ` Rusty Russell [this message]
2011-12-02 23:07   ` Benjamin Herrenschmidt
2011-12-03 17:38     ` Paolo Bonzini
2011-12-03 22:22       ` Benjamin Herrenschmidt
2011-12-05 10:08         ` Paolo Bonzini
2011-11-30 13:54 ` [PATCH 2/2] virtio-scsi: add error handling Paolo Bonzini
2011-12-05 17:29 [PATCH v2 0/2] virtio-scsi driver Paolo Bonzini
2011-12-05 17:29 ` [PATCH 1/2] virtio-scsi: first version Paolo Bonzini
2011-12-06 18:09   ` James Bottomley
2011-12-07  9:41     ` Paolo Bonzini
2011-12-07 14:35       ` James Bottomley
2011-12-08 13:09         ` Paolo Bonzini
2011-12-09 20:06           ` James Bottomley
2011-12-10 16:37             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739d3stmx.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome