mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Eric Paris <eparis@redhat.com>, Nick Piggin <npiggin@suse.de>,
	Andi Kleen <andi@firstfloor.org>,
	David Howells <dhowells@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos
Date: Mon, 18 Jan 2010 10:59:10 +0900	[thread overview]
Message-ID: <873a24kwb5.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20100118104913.66c8d90c.kamezawa.hiroyu@jp.fujitsu.com> (KAMEZAWA Hiroyuki's message of "Mon, 18 Jan 2010 10:49:13 +0900")

KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:

>> BTW, another concern by negative "pos" value is, the following like code
>> 
>> 	pos >> shift_bits
>> 
>> it will break the above. So, I think it should be checked if not yet.
>
> Where do we check ?
>
> FMODE_NEG_OFFSET is just used by /dev/mem and /proc/<pid>/mem. And I don't
> think there are no additonal users. So, I myself don't have has such concerns...

Sorry, it's just my concern. I'm not checking real path (e.g. vfs) of
related to /dev/mem, if there is no user of such code, it's ok.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

      reply	other threads:[~2010-01-18  1:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-15  1:39 [PATCH 0/6] FMODE_NONOTIFY, FMODE_RANDOM and FMODE_NEG_OFFSET bits Wu Fengguang
2010-01-15  1:39 ` [PATCH 1/6] fanotify: fix FMODE_NONOTIFY bit number Wu Fengguang
2010-01-15  1:39 ` [PATCH 2/6] bitops: compile time optimization for hweight_long(CONSTANT) Wu Fengguang
2010-01-15  1:39 ` [PATCH 3/6] vfs: O_* bit numbers uniqueness check Wu Fengguang
2010-01-15  1:39 ` [PATCH 4/6] vfs: take f_lock on modifying f_mode after open time Wu Fengguang
2010-01-15  1:39 ` [PATCH 5/6] readahead: introduce FMODE_RANDOM for POSIX_FADV_RANDOM Wu Fengguang
2010-01-15  1:40 ` [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos Wu Fengguang
2010-01-16 12:54   ` OGAWA Hirofumi
2010-01-18  0:15     ` KAMEZAWA Hiroyuki
2010-01-18  1:17       ` OGAWA Hirofumi
2010-01-18  1:25         ` KAMEZAWA Hiroyuki
2010-01-18  1:38           ` OGAWA Hirofumi
2010-01-18  2:00             ` KAMEZAWA Hiroyuki
2010-01-18  2:13               ` OGAWA Hirofumi
2010-01-18  2:30                 ` KAMEZAWA Hiroyuki
2010-01-18  3:15                   ` Wu, Fengguang
2010-01-18  3:22                     ` KAMEZAWA Hiroyuki
2010-01-18  5:26                       ` Wu, Fengguang
2010-01-19  0:37                         ` KAMEZAWA Hiroyuki
2010-01-18  1:32         ` OGAWA Hirofumi
2010-01-18  1:49           ` KAMEZAWA Hiroyuki
2010-01-18  1:59             ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873a24kwb5.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=corbet@lwn.net \
    --cc=dhowells@redhat.com \
    --cc=eparis@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=hch@infradead.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®