From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@osdl.org>
Cc: Damien Wyart <damien.wyart@free.fr>,
linux-kernel <linux-kernel@vger.kernel.org>,
Nick Piggin <npiggin@suse.de>
Subject: Re: 2.6.19-rc2-mm2 : empty files on vfat file system
Date: Sun, 22 Oct 2006 05:38:38 +0900 [thread overview]
Message-ID: <873b9htne9.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <20061021131932.09801b4a.akpm@osdl.org> (Andrew Morton's message of "Sat\, 21 Oct 2006 13\:19\:32 -0700")
Andrew Morton <akpm@osdl.org> writes:
> On Sat, 21 Oct 2006 19:38:49 +0200
> Damien Wyart <damien.wyart@free.fr> wrote:
>
>> > --- a/fs/fat/inode.c~fs-prepare_write-fixes
>> > +++ a/fs/fat/inode.c
>> > @@ -150,7 +150,11 @@ static int fat_commit_write(struct file
>> > unsigned from, unsigned to)
>> > {
>> > struct inode *inode = page->mapping->host;
>> > - int err = generic_commit_write(file, page, from, to);
>> > + int err;
>> > + if (to - from > 0)
>> > + return 0;
>> > +
>
> That should have been
>
> if (to - from == 0)
> return 0;
As I said in this thread, generic_cont_expand() uses "to == from".
Should we fix generic_cont_expand() instead? I don't know the
background of this patch.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2006-10-21 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-21 10:44 Damien Wyart
2006-10-21 13:24 ` OGAWA Hirofumi
2006-10-21 13:29 ` OGAWA Hirofumi
2006-10-21 17:38 ` Damien Wyart
2006-10-21 20:17 ` OGAWA Hirofumi
2006-10-21 20:19 ` Andrew Morton
2006-10-21 20:24 ` Andrew Morton
2006-10-22 1:34 ` Nick Piggin
2006-10-21 20:38 ` OGAWA Hirofumi [this message]
2006-10-22 1:50 ` Nick Piggin
2006-10-22 9:11 ` OGAWA Hirofumi
2006-10-22 9:25 ` Nick Piggin
2006-10-23 20:39 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873b9htne9.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=damien.wyart@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®