From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, reiserfs-dev@namesys.com
Subject: [PATCH 2/2] writeback: fix range handling
Date: Fri, 07 Apr 2006 01:18:59 +0900 [thread overview]
Message-ID: <873bgqn0cs.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <877j62n0l7.fsf@duaron.myhome.or.jp> (OGAWA Hirofumi's message of "Fri, 07 Apr 2006 01:13:56 +0900")
reiser4 doesn't check wbc->end, and perhaps it does not use cyclic
behavior. So, I guess this is ok.
Could you review this?
---
fs/reiser4/entd.c | 8 ++++----
fs/reiser4/plugin/file/file.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff -puN fs/reiser4/entd.c~wbc-range-cleanup-reiser4 fs/reiser4/entd.c
--- linux-2.6-akpm/fs/reiser4/entd.c~wbc-range-cleanup-reiser4 2006-04-06 05:44:56.000000000 +0900
+++ linux-2.6-akpm-hirofumi/fs/reiser4/entd.c 2006-04-06 05:44:56.000000000 +0900
@@ -265,14 +265,14 @@ static void entd_flush(struct super_bloc
init_stack_context(&ctx, super);
ctx.entd = 1;
- rq->wbc->start = rq->page->index << PAGE_CACHE_SHIFT;
- rq->wbc->end = (rq->page->index + ENTD_CAPTURE_APAGE_BURST) << PAGE_CACHE_SHIFT;
+ rq->wbc->range_start = rq->page->index << PAGE_CACHE_SHIFT;
+ rq->wbc->range_end = (rq->page->index + ENTD_CAPTURE_APAGE_BURST) << PAGE_CACHE_SHIFT;
tmp = rq->wbc->nr_to_write;
rq->mapping->a_ops->writepages(rq->mapping, rq->wbc);
if (rq->wbc->nr_to_write > 0) {
- rq->wbc->start = 0;
- rq->wbc->end = 0;
+ rq->wbc->range_start = 0;
+ rq->wbc->range_end = LLONG_MAX;
generic_sync_sb_inodes(super, rq->wbc);
}
rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST;
diff -puN fs/reiser4/plugin/file/file.c~wbc-range-cleanup-reiser4 fs/reiser4/plugin/file/file.c
--- linux-2.6-akpm/fs/reiser4/plugin/file/file.c~wbc-range-cleanup-reiser4 2006-04-06 05:44:56.000000000 +0900
+++ linux-2.6-akpm-hirofumi/fs/reiser4/plugin/file/file.c 2006-04-06 05:44:56.000000000 +0900
@@ -1550,7 +1550,7 @@ writepages_unix_file(struct address_spac
result = 0;
goto end;
}
- jindex = pindex = wbc->start >> PAGE_CACHE_SHIFT;
+ jindex = pindex = wbc->range_start >> PAGE_CACHE_SHIFT;
result = 0;
nr_pages =
(i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
_
next prev parent reply other threads:[~2006-04-06 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 16:13 [PATCH 1/2] " OGAWA Hirofumi
2006-04-06 16:18 ` OGAWA Hirofumi [this message]
2006-04-06 17:51 ` [PATCH 2/2] " OGAWA Hirofumi
2006-04-06 16:20 ` [PATCH 1/2] " OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873bgqn0cs.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®