From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "Andrew Reiter" <areiter@preventsys.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: NULL pointer in proc_pid_stat -- oops.
Date: Mon, 29 Mar 2004 02:00:03 +0900 [thread overview]
Message-ID: <873c7sewks.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <8758F8D58219684FAB0239EE8967048A4A7D5E@calculon.preventsys.com>
"Andrew Reiter" <areiter@preventsys.com> writes:
> 0x000004d4 <proc_pid_stat+124>: test %ecx,%ecx
> 0x000004d6 <proc_pid_stat+126>: je 0x510 <proc_pid_stat+184>
> 0x000004d8 <proc_pid_stat+128>: mov 0x98(%ecx),%eax
> 0x000004de <proc_pid_stat+134>: mov %eax,0x20(%esp,1)
> 0x000004e2 <proc_pid_stat+138>: mov 0x4(%ecx),%edx
> 0x000004e5 <proc_pid_stat+141>: movswl 0x64(%edx),%eax
> 0x000004e9 <proc_pid_stat+145>: movswl 0x66(%edx),%edx
> 0x000004ed <proc_pid_stat+149>: shl $0x14,%eax
> 0x000004f0 <proc_pid_stat+152>: or %edx,%eax
> 0x000004f2 <proc_pid_stat+154>: add 0x8(%ecx),%eax
>
> And from the oops trace output (that is attached), we can see that %edx
> is 0x0; so we can easily see here why we're crashing at least. After
> examining the C source, I see that we're dying in the call to
> task_name() (inline) from proc_pid_stat().
Looks like this problem is same with BSD acct Oops.
if (task->tty) {
tty_pgrp = task->tty->pgrp;
tty_nr = new_encode_dev(tty_devnum(task->tty));
}
Some place doesn't take the any lock for ->tty. I think we need to
take the lock for ->tty.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2004-03-28 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 21:13 Andrew Reiter
2004-03-28 17:00 ` OGAWA Hirofumi [this message]
2004-03-30 17:09 Andrew Reiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873c7sewks.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=areiter@preventsys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®