From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793664537; b=SIkPqIAw6h7mRIyrKrapye8Mp34QGe5+2ywcLVTRyCjqhJh+ztrqjZK0ELYQyhdP182+ ku1fmos+Ax/4T2SRTecue60L1gZjifkZgWC5AlqOdl/pvJn3IJTU0pdrlOSyuxthYMhtO OvXl8HmibLorEv1gcEILzLyqHglMryry3RWV5B1LCmMb2ByS0FlIjnzfmaUOOGOJNfSMt EjoD5oLbbnmztbnJmE7J1ponzdmoStzYjTwP9CgC9oGsLKmmMXi/6m76x+etzG/1c605K NoC7eHT88PqKH4zPRfmQYeQI2Fsk+btzzrOMh6vSeitZob8tecK5qawimTQBiiBxq0A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793664537; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:Autocrypt:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=BShTI+UobISHlwtvnbR0ufLcpJkUNzJIdEPohOxpHf4=; b=UZjP4o+bKaGVM8+Q3jZCQwfMfxlXKJWlNYKStOXLp7LoLKm0qtuEZ29fgha9jjnAO5GY VtUszQomTZfwEYJX5dGwQ7dbPo8RD1R3P9xvjed4rCO8TOxyc90YmIeE7AdtRsfvTGaCC JbYVadi0iBMk92D7c0bIcFIHdeN07T3hEJtAgH0pqByVkDEEVL71DHhmF7IlQ9pkfGabZ 0tBBHH4p8gD2X6+HjMEJl/yw3LPsiOajfsQMSm/IfGms8NEOz4fB8BBY4jP7E9nkzHHOI JIsBDHsr2Lq+6eOzt/rL2x0974MmAlbBmiKKV7NybnWr8KVpJh02xUTT3W1h0+y4UTg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=CpX3Ke6g; arc=none smtp.remote-ip=209.85.128.54 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D13CF606A324 for ; Tue, 3 Nov 2026 00:08:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D13CF606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=CpX3Ke6g Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4a214c5c4c0so31528545e9.3 for ; Mon, 02 Nov 2026 16:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1793664535; x=1794269335; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BShTI+UobISHlwtvnbR0ufLcpJkUNzJIdEPohOxpHf4=; b=CpX3Ke6g70akGgdDbzuTxgVpruv3xYq8FXN9MJO08DWtxiCDqIC9fKQ+C5nGfBcfKG v7GApdisZ5enj7u4SnIvU/Qk+8j4pCzSqx2JlLu884vo2bL4bq7AtHdAwEsR4TXrsvsi Q0sjgKrjkySKJj7FaBIOHv6FBd0ToArEOcbjOZU9HHXtwaKb7G4aHYZt0xQsoBmMucMR QEt3j02ts+IcA29L4KsMidGa/LtGbc6KAfTu9ElmhZlJsOJVetb16YlzM3+QBay5z4MA giuvcKksXpNP6hbyRsn7RDP1b4ggYbEvZTuNOh2ALfYCEEa8gbobDaO+EwgH62CESrXM HuUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793664535; x=1794269335; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BShTI+UobISHlwtvnbR0ufLcpJkUNzJIdEPohOxpHf4=; b=w3mAke9ugMho57Ls8Rc+vJ9+bAe1eUIRdY+1h0oZzqe7q64aPNcDKoQEh9f4YpoA3U DhROHhaYPxXcPa7GmorWjQn+SJle0qVt4dTGfnObgzGHQsPlPQ3ifUpHrQQPE+rguz/v 79wUeVC7C6VSK2vbbIaUENGxzSuNLZqNdvTTU8/qvvNBlB5yVpfmZwBPP6Va1cQHJ010 TXu+BkcmzaRUjtvg6kOVuTauYVOfB/fEqiTER0uRhItELE0UIUTQj5dROdvsnSczzTJe b73Vy2NXZU1X8HSUrs147TRGHrYlLs4gcXnv3Dbp1ILZTjjFdxFKixD+LFG/bE3mmds3 4MtQ== X-Forwarded-Encrypted: i=1; AKwUvBzFmNTRVwxjo1hmzO1b63ENXL8lZQXPchnQDf0J6hYYJMKJ+eYcuGzjEE29ZE9KCWIdYG6AVriuAPTVC8s=@vger.kernel.org X-Gm-Message-State: AFq9FYIoWeH+PGSnpeJCtv9tdxPz8UyBcz2RjQTmMbojAWctv245ptX+ Nt82XtzXGBCDaI4ZZGRngsXJ6thmFQdPMuY74LntjeCyUElV3tbt3tTGPKobV+YbVVatXsU/N1c PZ3UEWDt13w== X-Gm-Gg: AYBFou3538FjLyzkdvayIfjJYmkn0kYbr8JAoSb0ZKdnhqhWDr8EZgt/C716I62eryC PzIfJ05dcmTLZZ68DrUud2bUCk5ZtIgKlweUjj1GY0R/tIGUmUHdK7uVHJ7xtwRhIDMMrH+NtuZ T0XqeLqNOJEG5fb82mnSMl8ldna6rDrFrlDWcF8lJU+sy+Ux8Uf94/wZ2psSKeojwnadOSaPoQM uD6wPBjJ4H+SP4oU9Ke3FVrgqE4plOXJOOMae2MpXY1aKk+loW8WiVZkXng5wkxe0M+S1JHjwj+ 5cY8bUziLZVyp8j9AX2lz+N+9ZhQOY0H98b0JYKTyf3L2HADuOUGt2BhCE+seYymeNKDNGUHTgp PGW92XypbaIuRLY9VBGvxz3DOXQ6LhGBQ1Tw1N8wXjs0zTbiU4X0rb+arXW8UCrO87JUlBwXqBM nKdvuiRkSRJoJa4vNf45KsmF1mAHn8VOwF5TiVK1RUxiEAYRNVBzuTIztm8t1Ah3ZTVLRjeevMD lFbKfOl2dr4cqjhMUyzc8i4ttl2jfdbVaIqYtJwVgkXZIMtqjhV+YbU3md6fR6If1C+39hq2HMl CdDYUFLY3KNISfwpo63oXA== X-Received: by 2002:a05:600c:3b97:b0:4a3:5a91:5f64 with SMTP id 5b1f17b1804b1-4ac18e5dcbamr256643425e9.27.1793664535225; Mon, 02 Nov 2026 16:08:55 -0800 (PST) Received: from [172.16.0.229] ([159.196.52.54]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a429018casm36727241eec.14.2026.11.02.16.08.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2026 16:08:54 -0800 (PST) Message-ID: <8743c195-1204-4829-85ae-342bdab6503c@suse.com> Date: Tue, 3 Nov 2026 10:38:49 +1030 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: do not check support for an invalid sectorsize To: Siddharth Mishra Cc: David Sterba , Chris Mason , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Siddharth Mishra , stable@vger.kernel.org References: <20261102233041.310900-1-smish149@asu.edu> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJq3ujyBQkUpLw5AAoJEMI9kfOh Jf6o8OIH/0mqW+TQM4m2x3hCsnK+oB4yJH1qnGvIhFF/Lhs48wI02sGh6/4aA0hkCDfd9LHQ +ci4FUepZ9y4VS01+oIExbg/8ytzGYTzLtb44jK2GBOBVSJkMiha6jp22XFt7WUkT/tvbreu WWdGsaJIRQaZChy7xsMI8lqQ2WdmluZJ4LT0wD3l/l6QU1ZseMGySebdY9sVOQEOJNV7Qj92 /KOAFNmeZshV/qDI8Iw1RTs6TvLqCcqmlZLCmJkYSVhT1RonWRren8xIRcFEgMe004IDnt7V qdQhk/nhTS9x9MBAhMRl0TTE1VKDLvVALsud3iZLrmmtYvwPApzGJk052f0m28vOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJq3ukKBQkUzDspAAoJEMI9kfOhJf6o SNsH/1ysUWOKmzY0rGS3ZdS61QgqMGhSWD/EJ4UiPw+xO4l4+GtX0fOAqxqsmBKqje3vyhBa Z5o/1Y+gNiN+E6RBcSz4b1TAd78sQ2bvT5DWOvBjeeVxHdiuQMIn4S8xk5ZpySBw5ifjoiuL 0M33UVtJOzM8yfAeL+d/Rp4leJw72SutjkLyZTG/gJIp4pJGD/kFHn24OLL0IxEcO0gOekNZ os5e1R6jAJ2ILk7+MDnvU8wXHcCiVzuDhJLI1tih1uUIE50muHQJWbYuVBbdJeu8WlIDDssx UOCxLylNG3gDXV5MhLubPTOpp9OiFc/XC37nvkgEcrlmlOFBv4/NJCbECpo= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/11/3 10:36, Siddharth Mishra 写道: > On Mon, Nov 2, 2026 at 4:42 PM Qu Wenruo wrote: >>> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c >>> index 8e8fb942d..b348591f8 100644 >>> --- a/fs/btrfs/disk-io.c >>> +++ b/fs/btrfs/disk-io.c >>> @@ -2520,9 +2520,7 @@ int btrfs_validate_super(const struct btrfs_fs_info *fs_info, >>> sectorsize > BTRFS_MAX_METADATA_BLOCKSIZE)) { >>> btrfs_err(fs_info, "invalid sectorsize %u", sectorsize); >>> ret = -EINVAL; >>> - } >>> - >>> - if (unlikely(!btrfs_supported_blocksize(sectorsize))) { >>> + } else if (unlikely(!btrfs_supported_blocksize(sectorsize))) { >> >> If you want to change this, you should touch all callsites. >> Not only this one, but every unlikely() branch to return immediately. >> >> I do not like the ad-hoc fix just be cause you can trigger an ASSERT(). > > Thanks for the response. I'm assuming you mean I change the whole function > to return -EINVAL on the first failure it encounters and not just the sectorsize > because it reached an ASSERT. Given that, I'll send a v2 right away where > any failed check in btrfs_validate_super() returns early rather than > continuing ahead. Already done https://lore.kernel.org/linux-btrfs/7350d541824422978116bfb536d2c7bc68cbb826.1793664043.git.wqu@suse.com/ > > Siddharth Mishra