From: <Claudiu.Beznea@microchip.com>
To: <Conor.Dooley@microchip.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<Nicolas.Ferre@microchip.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [net-next PATCH v2 3/5] net: macb: unify macb_config alignment style
Date: Tue, 5 Jul 2022 07:19:54 +0000 [thread overview]
Message-ID: <8747ac2c-4363-4fc2-8139-08d21a778677@microchip.com> (raw)
In-Reply-To: <20220704114511.1892332-4-conor.dooley@microchip.com>
On 04.07.2022 14:45, Conor Dooley wrote:
> The various macb_config structs have taken different appraches to
s/appraches/approaches
> alignment when broken over newlines. Pick one style and make them
> match.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index d43bcf256b02..85a2e1ea7826 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4626,8 +4626,8 @@ static const struct macb_config at91sam9260_config = {
> };
>
> static const struct macb_config sama5d3macb_config = {
> - .caps = MACB_CAPS_SG_DISABLED
> - | MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII,
> + .caps = MACB_CAPS_SG_DISABLED |
> + MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII,
> .clk_init = macb_clk_init,
> .init = macb_init,
> .usrio = &macb_default_usrio,
> @@ -4658,8 +4658,8 @@ static const struct macb_config sama5d29_config = {
> };
>
> static const struct macb_config sama5d3_config = {
> - .caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE
> - | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_JUMBO,
> + .caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE |
> + MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_JUMBO,
> .dma_burst_length = 16,
> .clk_init = macb_clk_init,
> .init = macb_init,
> @@ -4731,8 +4731,8 @@ static int init_reset_optional(struct platform_device *pdev)
>
> static const struct macb_config zynqmp_config = {
> .caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE |
> - MACB_CAPS_JUMBO |
> - MACB_CAPS_GEM_HAS_PTP | MACB_CAPS_BD_RD_PREFETCH,
> + MACB_CAPS_JUMBO |
> + MACB_CAPS_GEM_HAS_PTP | MACB_CAPS_BD_RD_PREFETCH,
> .dma_burst_length = 16,
> .clk_init = macb_clk_init,
> .init = init_reset_optional,
> @@ -4806,8 +4806,8 @@ MODULE_DEVICE_TABLE(of, macb_dt_ids);
>
> static const struct macb_config default_gem_config = {
> .caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE |
> - MACB_CAPS_JUMBO |
> - MACB_CAPS_GEM_HAS_PTP,
> + MACB_CAPS_JUMBO |
> + MACB_CAPS_GEM_HAS_PTP,
> .dma_burst_length = 16,
> .clk_init = macb_clk_init,
> .init = macb_init,
next prev parent reply other threads:[~2022-07-05 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 11:45 [net-next PATCH v2 0/5] PolarFire SoC macb reset support Conor Dooley
2022-07-04 11:45 ` [net-next PATCH v2 1/5] dt-bindings: net: cdns,macb: document polarfire soc's macb Conor Dooley
2022-07-04 11:45 ` [net-next PATCH v2 2/5] net: macb: add polarfire soc reset support Conor Dooley
2022-07-04 11:45 ` [net-next PATCH v2 3/5] net: macb: unify macb_config alignment style Conor Dooley
2022-07-05 7:19 ` Claudiu.Beznea [this message]
2022-07-04 11:45 ` [net-next PATCH v2 4/5] net: macb: simplify error paths in init_reset_optional() Conor Dooley
2022-07-04 11:45 ` [net-next PATCH v2 5/5] net: macb: sort init_reset_optional() with other init()s Conor Dooley
2022-07-05 7:20 ` [net-next PATCH v2 0/5] PolarFire SoC macb reset support Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8747ac2c-4363-4fc2-8139-08d21a778677@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®